diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2019-07-12 20:31:19 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2019-07-12 20:31:19 -0400 |
commit | 23bbbf5c1fb3ddf104c2ddbda4cc24ebe53a3453 (patch) | |
tree | 8a3c882dcddc89175efb93236b6f57036165eb88 /net/9p | |
parent | a641a88e5d6864f20b2608cb01165c756794e645 (diff) | |
parent | 80a316ff16276b36d0392a8f8b2f63259857ae98 (diff) |
Merge tag '9p-for-5.3' of git://github.com/martinetd/linux
Pull 9p updates from Dominique Martinet:
"Two small fixes to properly cleanup the 9p transports list if
virtio/xen module initialization fail.
9p might otherwise try to access memory from a module that failed to
register got freed"
* tag '9p-for-5.3' of git://github.com/martinetd/linux:
9p/xen: Add cleanup path in p9_trans_xen_init
9p/virtio: Add cleanup path in p9_virtio_init
Diffstat (limited to 'net/9p')
-rw-r--r-- | net/9p/trans_virtio.c | 8 | ||||
-rw-r--r-- | net/9p/trans_xen.c | 8 |
2 files changed, 14 insertions, 2 deletions
diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c index 549938af02e7..a3cd90a74012 100644 --- a/net/9p/trans_virtio.c +++ b/net/9p/trans_virtio.c | |||
@@ -767,10 +767,16 @@ static struct p9_trans_module p9_virtio_trans = { | |||
767 | /* The standard init function */ | 767 | /* The standard init function */ |
768 | static int __init p9_virtio_init(void) | 768 | static int __init p9_virtio_init(void) |
769 | { | 769 | { |
770 | int rc; | ||
771 | |||
770 | INIT_LIST_HEAD(&virtio_chan_list); | 772 | INIT_LIST_HEAD(&virtio_chan_list); |
771 | 773 | ||
772 | v9fs_register_trans(&p9_virtio_trans); | 774 | v9fs_register_trans(&p9_virtio_trans); |
773 | return register_virtio_driver(&p9_virtio_drv); | 775 | rc = register_virtio_driver(&p9_virtio_drv); |
776 | if (rc) | ||
777 | v9fs_unregister_trans(&p9_virtio_trans); | ||
778 | |||
779 | return rc; | ||
774 | } | 780 | } |
775 | 781 | ||
776 | static void __exit p9_virtio_cleanup(void) | 782 | static void __exit p9_virtio_cleanup(void) |
diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c index 29420ebb8f07..3963eb11c3fb 100644 --- a/net/9p/trans_xen.c +++ b/net/9p/trans_xen.c | |||
@@ -530,13 +530,19 @@ static struct xenbus_driver xen_9pfs_front_driver = { | |||
530 | 530 | ||
531 | static int p9_trans_xen_init(void) | 531 | static int p9_trans_xen_init(void) |
532 | { | 532 | { |
533 | int rc; | ||
534 | |||
533 | if (!xen_domain()) | 535 | if (!xen_domain()) |
534 | return -ENODEV; | 536 | return -ENODEV; |
535 | 537 | ||
536 | pr_info("Initialising Xen transport for 9pfs\n"); | 538 | pr_info("Initialising Xen transport for 9pfs\n"); |
537 | 539 | ||
538 | v9fs_register_trans(&p9_xen_trans); | 540 | v9fs_register_trans(&p9_xen_trans); |
539 | return xenbus_register_frontend(&xen_9pfs_front_driver); | 541 | rc = xenbus_register_frontend(&xen_9pfs_front_driver); |
542 | if (rc) | ||
543 | v9fs_unregister_trans(&p9_xen_trans); | ||
544 | |||
545 | return rc; | ||
540 | } | 546 | } |
541 | module_init(p9_trans_xen_init); | 547 | module_init(p9_trans_xen_init); |
542 | 548 | ||