Merge branch 'misc.poll' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

Pull poll annotations from Al Viro:
 "This introduces a __bitwise type for POLL### bitmap, and propagates
  the annotations through the tree. Most of that stuff is as simple as
  'make ->poll() instances return __poll_t and do the same to local
  variables used to hold the future return value'.

  Some of the obvious brainos found in process are fixed (e.g. POLLIN
  misspelled as POLL_IN). At that point the amount of sparse warnings is
  low and most of them are for genuine bugs - e.g. ->poll() instance
  deciding to return -EINVAL instead of a bitmap. I hadn't touched those
  in this series - it's large enough as it is.

  Another problem it has caught was eventpoll() ABI mess; select.c and
  eventpoll.c assumed that corresponding POLL### and EPOLL### were
  equal. That's true for some, but not all of them - EPOLL### are
  arch-independent, but POLL### are not.

  The last commit in this series separates userland POLL### values from
  the (now arch-independent) kernel-side ones, converting between them
  in the few places where they are copied to/from userland. AFAICS, this
  is the least disruptive fix preserving poll(2) ABI and making epoll()
  work on all architectures.

  As it is, it's simply broken on sparc - try to give it EPOLLWRNORM and
  it will trigger only on what would've triggered EPOLLWRBAND on other
  architectures. EPOLLWRBAND and EPOLLRDHUP, OTOH, are never triggered
  at all on sparc. With this patch they should work consistently on all
  architectures"

* 'misc.poll' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (37 commits)
  make kernel-side POLL... arch-independent
  eventpoll: no need to mask the result of epi_item_poll() again
  eventpoll: constify struct epoll_event pointers
  debugging printk in sg_poll() uses %x to print POLL... bitmap
  annotate poll(2) guts
  9p: untangle ->poll() mess
  ->si_band gets POLL... bitmap stored into a user-visible long field
  ring_buffer_poll_wait() return value used as return value of ->poll()
  the rest of drivers/*: annotate ->poll() instances
  media: annotate ->poll() instances
  fs: annotate ->poll() instances
  ipc, kernel, mm: annotate ->poll() instances
  net: annotate ->poll() instances
  apparmor: annotate ->poll() instances
  tomoyo: annotate ->poll() instances
  sound: annotate ->poll() instances
  acpi: annotate ->poll() instances
  crypto: annotate ->poll() instances
  block: annotate ->poll() instances
  x86: annotate ->poll() instances
  ...

1 files changed, 30 insertions, 30 deletions

diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
index 80f5c79053a4..d6f7f7cb79c4 100644
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -228,32 +228,31 @@ static void p9_conn_cancel(struct p9_conn *m, int err)
         }
 }
 
-static int
-p9_fd_poll(struct p9_client *client, struct poll_table_struct *pt)
+static __poll_t
+p9_fd_poll(struct p9_client *client, struct poll_table_struct *pt, int *err)
 {
-        int ret, n;
+        __poll_t ret, n;
         struct p9_trans_fd *ts = NULL;
 
         if (client && client->status == Connected)
                 ts = client->trans;
 
-        if (!ts)
-                return -EREMOTEIO;
+        if (!ts) {
+                if (err)
+                        *err = -EREMOTEIO;
+                return POLLERR;
+        }
 
         if (!ts->rd->f_op->poll)
-                return -EIO;
-
-        if (!ts->wr->f_op->poll)
-                return -EIO;
-
-        ret = ts->rd->f_op->poll(ts->rd, pt);
-        if (ret < 0)
-                return ret;
+                ret = DEFAULT_POLLMASK;
+        else
+                ret = ts->rd->f_op->poll(ts->rd, pt);
 
         if (ts->rd != ts->wr) {
-                n = ts->wr->f_op->poll(ts->wr, pt);
-                if (n < 0)
-                        return n;
+                if (!ts->wr->f_op->poll)
+                        n = DEFAULT_POLLMASK;
+                else
+                        n = ts->wr->f_op->poll(ts->wr, pt);
                 ret = (ret & ~POLLOUT) | (n & ~POLLIN);
         }
 
@@ -298,7 +297,8 @@ static int p9_fd_read(struct p9_client *client, void *v, int len)
 
 static void p9_read_work(struct work_struct *work)
 {
-        int n, err;
+        __poll_t n;
+        int err;
         struct p9_conn *m;
         int status = REQ_STATUS_ERROR;
 
@@ -398,7 +398,7 @@ end_clear:
                 if (test_and_clear_bit(Rpending, &m->wsched))
                         n = POLLIN;
                 else
-                        n = p9_fd_poll(m->client, NULL);
+                        n = p9_fd_poll(m->client, NULL, NULL);
 
                 if ((n & POLLIN) && !test_and_set_bit(Rworksched, &m->wsched)) {
                         p9_debug(P9_DEBUG_TRANS, "sched read work %p\n", m);
@@ -448,7 +448,8 @@ static int p9_fd_write(struct p9_client *client, void *v, int len)
 
 static void p9_write_work(struct work_struct *work)
 {
-        int n, err;
+        __poll_t n;
+        int err;
         struct p9_conn *m;
         struct p9_req_t *req;
 
@@ -506,7 +507,7 @@ end_clear:
                 if (test_and_clear_bit(Wpending, &m->wsched))
                         n = POLLOUT;
                 else
-                        n = p9_fd_poll(m->client, NULL);
+                        n = p9_fd_poll(m->client, NULL, NULL);
 
                 if ((n & POLLOUT) &&
                    !test_and_set_bit(Wworksched, &m->wsched)) {
@@ -581,7 +582,7 @@ p9_pollwait(struct file *filp, wait_queue_head_t *wait_address, poll_table *p)
 
 static void p9_conn_create(struct p9_client *client)
 {
-        int n;
+        __poll_t n;
         struct p9_trans_fd *ts = client->trans;
         struct p9_conn *m = &ts->conn;
 
@@ -597,7 +598,7 @@ static void p9_conn_create(struct p9_client *client)
         INIT_LIST_HEAD(&m->poll_pending_link);
         init_poll_funcptr(&m->pt, p9_pollwait);
 
-        n = p9_fd_poll(client, &m->pt);
+        n = p9_fd_poll(client, &m->pt, NULL);
         if (n & POLLIN) {
                 p9_debug(P9_DEBUG_TRANS, "mux %p can read\n", m);
                 set_bit(Rpending, &m->wsched);
@@ -617,17 +618,16 @@ static void p9_conn_create(struct p9_client *client)
 
 static void p9_poll_mux(struct p9_conn *m)
 {
-        int n;
+        __poll_t n;
+        int err = -ECONNRESET;
 
         if (m->err < 0)
                 return;
 
-        n = p9_fd_poll(m->client, NULL);
-        if (n < 0 || n & (POLLERR | POLLHUP | POLLNVAL)) {
+        n = p9_fd_poll(m->client, NULL, &err);
+        if (n & (POLLERR | POLLHUP | POLLNVAL)) {
                 p9_debug(P9_DEBUG_TRANS, "error mux %p err %d\n", m, n);
-                if (n >= 0)
-                        n = -ECONNRESET;
-                p9_conn_cancel(m, n);
+                p9_conn_cancel(m, err);
         }
 
         if (n & POLLIN) {
@@ -663,7 +663,7 @@ static void p9_poll_mux(struct p9_conn *m)
 
 static int p9_fd_request(struct p9_client *client, struct p9_req_t *req)
 {
-        int n;
+        __poll_t n;
         struct p9_trans_fd *ts = client->trans;
         struct p9_conn *m = &ts->conn;
 
@@ -680,7 +680,7 @@ static int p9_fd_request(struct p9_client *client, struct p9_req_t *req)
         if (test_and_clear_bit(Wpending, &m->wsched))
                 n = POLLOUT;
         else
-                n = p9_fd_poll(m->client, NULL);
+                n = p9_fd_poll(m->client, NULL, NULL);
 
         if (n & POLLOUT && !test_and_set_bit(Wworksched, &m->wsched))
                 schedule_work(&m->wq);