Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next

Pull networking updates from David Miller:

 1) Add Maglev hashing scheduler to IPVS, from Inju Song.

 2) Lots of new TC subsystem tests from Roman Mashak.

 3) Add TCP zero copy receive and fix delayed acks and autotuning with
    SO_RCVLOWAT, from Eric Dumazet.

 4) Add XDP_REDIRECT support to mlx5 driver, from Jesper Dangaard
    Brouer.

 5) Add ttl inherit support to vxlan, from Hangbin Liu.

 6) Properly separate ipv6 routes into their logically independant
    components. fib6_info for the routing table, and fib6_nh for sets of
    nexthops, which thus can be shared. From David Ahern.

 7) Add bpf_xdp_adjust_tail helper, which can be used to generate ICMP
    messages from XDP programs. From Nikita V. Shirokov.

 8) Lots of long overdue cleanups to the r8169 driver, from Heiner
    Kallweit.

 9) Add BTF ("BPF Type Format"), from Martin KaFai Lau.

10) Add traffic condition monitoring to iwlwifi, from Luca Coelho.

11) Plumb extack down into fib_rules, from Roopa Prabhu.

12) Add Flower classifier offload support to igb, from Vinicius Costa
    Gomes.

13) Add UDP GSO support, from Willem de Bruijn.

14) Add documentation for eBPF helpers, from Quentin Monnet.

15) Add TLS tx offload to mlx5, from Ilya Lesokhin.

16) Allow applications to be given the number of bytes available to read
    on a socket via a control message returned from recvmsg(), from
    Soheil Hassas Yeganeh.

17) Add x86_32 eBPF JIT compiler, from Wang YanQing.

18) Add AF_XDP sockets, with zerocopy support infrastructure as well.
    From Björn Töpel.

19) Remove indirect load support from all of the BPF JITs and handle
    these operations in the verifier by translating them into native BPF
    instead. From Daniel Borkmann.

20) Add GRO support to ipv6 gre tunnels, from Eran Ben Elisha.

21) Allow XDP programs to do lookups in the main kernel routing tables
    for forwarding. From David Ahern.

22) Allow drivers to store hardware state into an ELF section of kernel
    dump vmcore files, and use it in cxgb4. From Rahul Lakkireddy.

23) Various RACK and loss detection improvements in TCP, from Yuchung
    Cheng.

24) Add TCP SACK compression, from Eric Dumazet.

25) Add User Mode Helper support and basic bpfilter infrastructure, from
    Alexei Starovoitov.

26) Support ports and protocol values in RTM_GETROUTE, from Roopa
    Prabhu.

27) Support bulking in ->ndo_xdp_xmit() API, from Jesper Dangaard
    Brouer.

28) Add lots of forwarding selftests, from Petr Machata.

29) Add generic network device failover driver, from Sridhar Samudrala.

* ra.kernel.org:/pub/scm/linux/kernel/git/davem/net-next: (1959 commits)
  strparser: Add __strp_unpause and use it in ktls.
  rxrpc: Fix terminal retransmission connection ID to include the channel
  net: hns3: Optimize PF CMDQ interrupt switching process
  net: hns3: Fix for VF mailbox receiving unknown message
  net: hns3: Fix for VF mailbox cannot receiving PF response
  bnx2x: use the right constant
  Revert "net: sched: cls: Fix offloading when ingress dev is vxlan"
  net: dsa: b53: Fix for brcm tag issue in Cygnus SoC
  enic: fix UDP rss bits
  netdev-FAQ: clarify DaveM's position for stable backports
  rtnetlink: validate attributes in do_setlink()
  mlxsw: Add extack messages for port_{un, }split failures
  netdevsim: Add extack error message for devlink reload
  devlink: Add extack to reload and port_{un, }split operations
  net: metrics: add proper netlink validation
  ipmr: fix error path when ipmr_new_table fails
  ip6mr: only set ip6mr_table from setsockopt when ip6mr_new_table succeeds
  net: hns3: remove unused hclgevf_cfg_func_mta_filter
  netfilter: provide udp*_lib_lookup for nf_tproxy
  qed*: Utilize FW 8.37.2.0
  ...

4 files changed, 47 insertions, 16 deletions

diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index 5505ee6ebdbe..73a65789271b 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -118,17 +118,21 @@ void unregister_vlan_dev(struct net_device *dev, struct list_head *head)
 }
 
 int vlan_check_real_dev(struct net_device *real_dev,
-                        __be16 protocol, u16 vlan_id)
+                        __be16 protocol, u16 vlan_id,
+                        struct netlink_ext_ack *extack)
 {
         const char *name = real_dev->name;
 
         if (real_dev->features & NETIF_F_VLAN_CHALLENGED) {
                 pr_info("VLANs not supported on %s\n", name);
+                NL_SET_ERR_MSG_MOD(extack, "VLANs not supported on device");
                 return -EOPNOTSUPP;
         }
 
-        if (vlan_find_dev(real_dev, protocol, vlan_id) != NULL)
+        if (vlan_find_dev(real_dev, protocol, vlan_id) != NULL) {
+                NL_SET_ERR_MSG_MOD(extack, "VLAN device already exists");
                 return -EEXIST;
+        }
 
         return 0;
 }
@@ -215,7 +219,8 @@ static int register_vlan_device(struct net_device *real_dev, u16 vlan_id)
         if (vlan_id >= VLAN_VID_MASK)
                 return -ERANGE;
 
-        err = vlan_check_real_dev(real_dev, htons(ETH_P_8021Q), vlan_id);
+        err = vlan_check_real_dev(real_dev, htons(ETH_P_8021Q), vlan_id,
+                                  NULL);
         if (err < 0)
                 return err;
 
diff --git a/net/8021q/vlan.h b/net/8021q/vlan.h
index e23aac3e4d37..44df1c3df02d 100644
--- a/net/8021q/vlan.h
+++ b/net/8021q/vlan.h
@@ -109,7 +109,8 @@ int vlan_dev_change_flags(const struct net_device *dev, u32 flag, u32 mask);
 void vlan_dev_get_realdev_name(const struct net_device *dev, char *result);
 
 int vlan_check_real_dev(struct net_device *real_dev,
-                        __be16 protocol, u16 vlan_id);
+                        __be16 protocol, u16 vlan_id,
+                        struct netlink_ext_ack *extack);
 void vlan_setup(struct net_device *dev);
 int register_vlan_dev(struct net_device *dev, struct netlink_ext_ack *extack);
 void unregister_vlan_dev(struct net_device *dev, struct list_head *head);
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index 236452ebbd9e..546af0e73ac3 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -215,7 +215,9 @@ int vlan_dev_set_egress_priority(const struct net_device *dev,
         return 0;
 }
 
-/* Flags are defined in the vlan_flags enum in include/linux/if_vlan.h file. */
+/* Flags are defined in the vlan_flags enum in
+ * include/uapi/linux/if_vlan.h file.
+ */
 int vlan_dev_change_flags(const struct net_device *dev, u32 flags, u32 mask)
 {
         struct vlan_dev_priv *vlan = vlan_dev_priv(dev);
diff --git a/net/8021q/vlan_netlink.c b/net/8021q/vlan_netlink.c
index 6689c0b272a7..9b60c1e399e2 100644
--- a/net/8021q/vlan_netlink.c
+++ b/net/8021q/vlan_netlink.c
@@ -47,14 +47,20 @@ static int vlan_validate(struct nlattr *tb[], struct nlattr *data[],
         int err;
 
         if (tb[IFLA_ADDRESS]) {
-                if (nla_len(tb[IFLA_ADDRESS]) != ETH_ALEN)
+                if (nla_len(tb[IFLA_ADDRESS]) != ETH_ALEN) {
+                        NL_SET_ERR_MSG_MOD(extack, "Invalid link address");
                         return -EINVAL;
-                if (!is_valid_ether_addr(nla_data(tb[IFLA_ADDRESS])))
+                }
+                if (!is_valid_ether_addr(nla_data(tb[IFLA_ADDRESS]))) {
+                        NL_SET_ERR_MSG_MOD(extack, "Invalid link address");
                         return -EADDRNOTAVAIL;
+                }
         }
 
-        if (!data)
+        if (!data) {
+                NL_SET_ERR_MSG_MOD(extack, "VLAN properties not specified");
                 return -EINVAL;
+        }
 
         if (data[IFLA_VLAN_PROTOCOL]) {
                 switch (nla_get_be16(data[IFLA_VLAN_PROTOCOL])) {
@@ -62,29 +68,38 @@ static int vlan_validate(struct nlattr *tb[], struct nlattr *data[],
                 case htons(ETH_P_8021AD):
                         break;
                 default:
+                        NL_SET_ERR_MSG_MOD(extack, "Invalid VLAN protocol");
                         return -EPROTONOSUPPORT;
                 }
         }
 
         if (data[IFLA_VLAN_ID]) {
                 id = nla_get_u16(data[IFLA_VLAN_ID]);
-                if (id >= VLAN_VID_MASK)
+                if (id >= VLAN_VID_MASK) {
+                        NL_SET_ERR_MSG_MOD(extack, "Invalid VLAN id");
                         return -ERANGE;
+                }
         }
         if (data[IFLA_VLAN_FLAGS]) {
                 flags = nla_data(data[IFLA_VLAN_FLAGS]);
                 if ((flags->flags & flags->mask) &
                     ~(VLAN_FLAG_REORDER_HDR | VLAN_FLAG_GVRP |
-                      VLAN_FLAG_LOOSE_BINDING | VLAN_FLAG_MVRP))
+                      VLAN_FLAG_LOOSE_BINDING | VLAN_FLAG_MVRP)) {
+                        NL_SET_ERR_MSG_MOD(extack, "Invalid VLAN flags");
                         return -EINVAL;
+                }
         }
 
         err = vlan_validate_qos_map(data[IFLA_VLAN_INGRESS_QOS]);
-        if (err < 0)
+        if (err < 0) {
+                NL_SET_ERR_MSG_MOD(extack, "Invalid ingress QOS map");
                 return err;
+        }
         err = vlan_validate_qos_map(data[IFLA_VLAN_EGRESS_QOS]);
-        if (err < 0)
+        if (err < 0) {
+                NL_SET_ERR_MSG_MOD(extack, "Invalid egress QOS map");
                 return err;
+        }
         return 0;
 }
 
@@ -126,14 +141,21 @@ static int vlan_newlink(struct net *src_net, struct net_device *dev,
         __be16 proto;
         int err;
 
-        if (!data[IFLA_VLAN_ID])
+        if (!data[IFLA_VLAN_ID]) {
+                NL_SET_ERR_MSG_MOD(extack, "VLAN id not specified");
                 return -EINVAL;
+        }
 
-        if (!tb[IFLA_LINK])
+        if (!tb[IFLA_LINK]) {
+                NL_SET_ERR_MSG_MOD(extack, "link not specified");
                 return -EINVAL;
+        }
+
         real_dev = __dev_get_by_index(src_net, nla_get_u32(tb[IFLA_LINK]));
-        if (!real_dev)
+        if (!real_dev) {
+                NL_SET_ERR_MSG_MOD(extack, "link does not exist");
                 return -ENODEV;
+        }
 
         if (data[IFLA_VLAN_PROTOCOL])
                 proto = nla_get_be16(data[IFLA_VLAN_PROTOCOL]);
@@ -146,7 +168,8 @@ static int vlan_newlink(struct net *src_net, struct net_device *dev,
         dev->priv_flags |= (real_dev->priv_flags & IFF_XMIT_DST_RELEASE);
         vlan->flags      = VLAN_FLAG_REORDER_HDR;
 
-        err = vlan_check_real_dev(real_dev, vlan->vlan_proto, vlan->vlan_id);
+        err = vlan_check_real_dev(real_dev, vlan->vlan_proto, vlan->vlan_id,
+                                  extack);
         if (err < 0)
                 return err;