summaryrefslogtreecommitdiffstats
path: root/mm/slab.h
diff options
context:
space:
mode:
authorAlexey Dobriyan <adobriyan@gmail.com>2018-04-05 19:20:37 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2018-04-06 00:36:23 -0400
commitf4957d5bd09165b165df851fbf8c658f7fcd9922 (patch)
tree021c72366564d4082e2885999640b79d174e5296 /mm/slab.h
parent361d575e5c7a39c73a8a9bdd504c1d1274f280aa (diff)
slab: make kmem_cache_create() work with 32-bit sizes
struct kmem_cache::size and ::align were always 32-bit. Out of curiosity I created 4GB kmem_cache, it oopsed with division by 0. kmem_cache_create(1UL<<32+1) created 1-byte cache as expected. size_t doesn't work and never did. Link: http://lkml.kernel.org/r/20180305200730.15812-6-adobriyan@gmail.com Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Cc: Christoph Lameter <cl@linux.com> Cc: Pekka Enberg <penberg@kernel.org> Cc: David Rientjes <rientjes@google.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/slab.h')
-rw-r--r--mm/slab.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/mm/slab.h b/mm/slab.h
index 2a6d88044a56..0809580428fe 100644
--- a/mm/slab.h
+++ b/mm/slab.h
@@ -101,11 +101,11 @@ extern void create_boot_cache(struct kmem_cache *, const char *name,
101 unsigned int useroffset, unsigned int usersize); 101 unsigned int useroffset, unsigned int usersize);
102 102
103int slab_unmergeable(struct kmem_cache *s); 103int slab_unmergeable(struct kmem_cache *s);
104struct kmem_cache *find_mergeable(size_t size, size_t align, 104struct kmem_cache *find_mergeable(unsigned size, unsigned align,
105 slab_flags_t flags, const char *name, void (*ctor)(void *)); 105 slab_flags_t flags, const char *name, void (*ctor)(void *));
106#ifndef CONFIG_SLOB 106#ifndef CONFIG_SLOB
107struct kmem_cache * 107struct kmem_cache *
108__kmem_cache_alias(const char *name, size_t size, size_t align, 108__kmem_cache_alias(const char *name, unsigned int size, unsigned int align,
109 slab_flags_t flags, void (*ctor)(void *)); 109 slab_flags_t flags, void (*ctor)(void *));
110 110
111slab_flags_t kmem_cache_flags(unsigned long object_size, 111slab_flags_t kmem_cache_flags(unsigned long object_size,
@@ -113,7 +113,7 @@ slab_flags_t kmem_cache_flags(unsigned long object_size,
113 void (*ctor)(void *)); 113 void (*ctor)(void *));
114#else 114#else
115static inline struct kmem_cache * 115static inline struct kmem_cache *
116__kmem_cache_alias(const char *name, size_t size, size_t align, 116__kmem_cache_alias(const char *name, unsigned int size, unsigned int align,
117 slab_flags_t flags, void (*ctor)(void *)) 117 slab_flags_t flags, void (*ctor)(void *))
118{ return NULL; } 118{ return NULL; }
119 119