diff options
author | Tejun Heo <tj@kernel.org> | 2017-02-22 18:41:27 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2017-02-22 19:41:27 -0500 |
commit | c9fc586403e7c85eee06b2d5dea14ce71c00fcd8 (patch) | |
tree | 4edb0cd2ebf8b0439239fb1ebe511e3def80e39a /mm/slab.c | |
parent | 510ded33e075c2bd662b1efab0110f4240325fc9 (diff) |
slab: introduce __kmemcg_cache_deactivate()
__kmem_cache_shrink() is called with %true @deactivate only for memcg
caches. Remove @deactivate from __kmem_cache_shrink() and introduce
__kmemcg_cache_deactivate() instead. Each memcg-supporting allocator
should implement it and it should deactivate and drain the cache.
This is to allow memcg cache deactivation behavior to further deviate
from simple shrinking without messing up __kmem_cache_shrink().
This is pure reorganization and doesn't introduce any observable
behavior changes.
v2: Dropped unnecessary ifdef in mm/slab.h as suggested by Vladimir.
Link: http://lkml.kernel.org/r/20170117235411.9408-8-tj@kernel.org
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/slab.c')
-rw-r--r-- | mm/slab.c | 11 |
1 files changed, 9 insertions, 2 deletions
@@ -2315,7 +2315,7 @@ out: | |||
2315 | return nr_freed; | 2315 | return nr_freed; |
2316 | } | 2316 | } |
2317 | 2317 | ||
2318 | int __kmem_cache_shrink(struct kmem_cache *cachep, bool deactivate) | 2318 | int __kmem_cache_shrink(struct kmem_cache *cachep) |
2319 | { | 2319 | { |
2320 | int ret = 0; | 2320 | int ret = 0; |
2321 | int node; | 2321 | int node; |
@@ -2333,9 +2333,16 @@ int __kmem_cache_shrink(struct kmem_cache *cachep, bool deactivate) | |||
2333 | return (ret ? 1 : 0); | 2333 | return (ret ? 1 : 0); |
2334 | } | 2334 | } |
2335 | 2335 | ||
2336 | #ifdef CONFIG_MEMCG | ||
2337 | void __kmemcg_cache_deactivate(struct kmem_cache *cachep) | ||
2338 | { | ||
2339 | __kmem_cache_shrink(cachep); | ||
2340 | } | ||
2341 | #endif | ||
2342 | |||
2336 | int __kmem_cache_shutdown(struct kmem_cache *cachep) | 2343 | int __kmem_cache_shutdown(struct kmem_cache *cachep) |
2337 | { | 2344 | { |
2338 | return __kmem_cache_shrink(cachep, false); | 2345 | return __kmem_cache_shrink(cachep); |
2339 | } | 2346 | } |
2340 | 2347 | ||
2341 | void __kmem_cache_release(struct kmem_cache *cachep) | 2348 | void __kmem_cache_release(struct kmem_cache *cachep) |