diff options
author | Hugh Dickins <hughd@google.com> | 2018-11-30 17:10:13 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2018-11-30 17:56:14 -0500 |
commit | 906f9cdfc2a0800f13683f9e4ebdfd08c12ee81b (patch) | |
tree | 5976b8bd633f0c8a1eddc4aadfdbe62e5350b938 /mm/rmap.c | |
parent | 7c0950d455d6ab610d2990a13120f935b75abf2c (diff) |
mm/huge_memory: rename freeze_page() to unmap_page()
The term "freeze" is used in several ways in the kernel, and in mm it
has the particular meaning of forcing page refcount temporarily to 0.
freeze_page() is just too confusing a name for a function that unmaps a
page: rename it unmap_page(), and rename unfreeze_page() remap_page().
Went to change the mention of freeze_page() added later in mm/rmap.c,
but found it to be incorrect: ordinary page reclaim reaches there too;
but the substance of the comment still seems correct, so edit it down.
Link: http://lkml.kernel.org/r/alpine.LSU.2.11.1811261514080.2275@eggly.anvils
Fixes: e9b61f19858a5 ("thp: reintroduce split_huge_page()")
Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Jerome Glisse <jglisse@redhat.com>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: <stable@vger.kernel.org> [4.8+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/rmap.c')
-rw-r--r-- | mm/rmap.c | 13 |
1 files changed, 3 insertions, 10 deletions
@@ -1627,16 +1627,9 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma, | |||
1627 | address + PAGE_SIZE); | 1627 | address + PAGE_SIZE); |
1628 | } else { | 1628 | } else { |
1629 | /* | 1629 | /* |
1630 | * We should not need to notify here as we reach this | 1630 | * This is a locked file-backed page, thus it cannot |
1631 | * case only from freeze_page() itself only call from | 1631 | * be removed from the page cache and replaced by a new |
1632 | * split_huge_page_to_list() so everything below must | 1632 | * page before mmu_notifier_invalidate_range_end, so no |
1633 | * be true: | ||
1634 | * - page is not anonymous | ||
1635 | * - page is locked | ||
1636 | * | ||
1637 | * So as it is a locked file back page thus it can not | ||
1638 | * be remove from the page cache and replace by a new | ||
1639 | * page before mmu_notifier_invalidate_range_end so no | ||
1640 | * concurrent thread might update its page table to | 1633 | * concurrent thread might update its page table to |
1641 | * point at new page while a device still is using this | 1634 | * point at new page while a device still is using this |
1642 | * page. | 1635 | * page. |