summaryrefslogtreecommitdiffstats
path: root/mm/page_alloc.c
diff options
context:
space:
mode:
authorMichal Hocko <mhocko@suse.com>2017-09-06 19:23:36 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2017-09-06 20:27:29 -0400
commitc41f012ade0b95b0a6e25c7150673e0554736165 (patch)
treec3270264283dff1de402a6609b155c804c097320 /mm/page_alloc.c
parent4da243ac1cf6aeb30b7c555d56208982d66d6d33 (diff)
mm: rename global_page_state to global_zone_page_state
global_page_state is error prone as a recent bug report pointed out [1]. It only returns proper values for zone based counters as the enum it gets suggests. We already have global_node_page_state so let's rename global_page_state to global_zone_page_state to be more explicit here. All existing users seems to be correct: $ git grep "global_page_state(NR_" | sed 's@.*(\(NR_[A-Z_]*\)).*@\1@' | sort | uniq -c 2 NR_BOUNCE 2 NR_FREE_CMA_PAGES 11 NR_FREE_PAGES 1 NR_KERNEL_STACK_KB 1 NR_MLOCK 2 NR_PAGETABLE This patch shouldn't introduce any functional change. [1] http://lkml.kernel.org/r/201707260628.v6Q6SmaS030814@www262.sakura.ne.jp Link: http://lkml.kernel.org/r/20170801134256.5400-2-hannes@cmpxchg.org Signed-off-by: Michal Hocko <mhocko@suse.com> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> Cc: Josef Bacik <josef@toxicpanda.com> Cc: Vladimir Davydov <vdavydov.dev@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/page_alloc.c')
-rw-r--r--mm/page_alloc.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 0bea94af0423..a4562c058ec4 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4509,7 +4509,7 @@ long si_mem_available(void)
4509 * Estimate the amount of memory available for userspace allocations, 4509 * Estimate the amount of memory available for userspace allocations,
4510 * without causing swapping. 4510 * without causing swapping.
4511 */ 4511 */
4512 available = global_page_state(NR_FREE_PAGES) - totalreserve_pages; 4512 available = global_zone_page_state(NR_FREE_PAGES) - totalreserve_pages;
4513 4513
4514 /* 4514 /*
4515 * Not all the page cache can be freed, otherwise the system will 4515 * Not all the page cache can be freed, otherwise the system will
@@ -4538,7 +4538,7 @@ void si_meminfo(struct sysinfo *val)
4538{ 4538{
4539 val->totalram = totalram_pages; 4539 val->totalram = totalram_pages;
4540 val->sharedram = global_node_page_state(NR_SHMEM); 4540 val->sharedram = global_node_page_state(NR_SHMEM);
4541 val->freeram = global_page_state(NR_FREE_PAGES); 4541 val->freeram = global_zone_page_state(NR_FREE_PAGES);
4542 val->bufferram = nr_blockdev_pages(); 4542 val->bufferram = nr_blockdev_pages();
4543 val->totalhigh = totalhigh_pages; 4543 val->totalhigh = totalhigh_pages;
4544 val->freehigh = nr_free_highpages(); 4544 val->freehigh = nr_free_highpages();
@@ -4673,11 +4673,11 @@ void show_free_areas(unsigned int filter, nodemask_t *nodemask)
4673 global_node_page_state(NR_SLAB_UNRECLAIMABLE), 4673 global_node_page_state(NR_SLAB_UNRECLAIMABLE),
4674 global_node_page_state(NR_FILE_MAPPED), 4674 global_node_page_state(NR_FILE_MAPPED),
4675 global_node_page_state(NR_SHMEM), 4675 global_node_page_state(NR_SHMEM),
4676 global_page_state(NR_PAGETABLE), 4676 global_zone_page_state(NR_PAGETABLE),
4677 global_page_state(NR_BOUNCE), 4677 global_zone_page_state(NR_BOUNCE),
4678 global_page_state(NR_FREE_PAGES), 4678 global_zone_page_state(NR_FREE_PAGES),
4679 free_pcp, 4679 free_pcp,
4680 global_page_state(NR_FREE_CMA_PAGES)); 4680 global_zone_page_state(NR_FREE_CMA_PAGES));
4681 4681
4682 for_each_online_pgdat(pgdat) { 4682 for_each_online_pgdat(pgdat) {
4683 if (show_mem_node_skip(filter, pgdat->node_id, nodemask)) 4683 if (show_mem_node_skip(filter, pgdat->node_id, nodemask))