diff options
author | Joonsoo Kim <iamjoonsoo.kim@lge.com> | 2016-05-19 20:10:49 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-05-19 22:12:14 -0400 |
commit | 0139aa7b7fa12ceef095d99dc36606a5b10ab83a (patch) | |
tree | 94da74f2f79911a11a3c7c34f73ba971dec41a7e /mm/page_alloc.c | |
parent | 6d061f9f6136d477932088c24ce155d7dc785746 (diff) |
mm: rename _count, field of the struct page, to _refcount
Many developers already know that field for reference count of the
struct page is _count and atomic type. They would try to handle it
directly and this could break the purpose of page reference count
tracepoint. To prevent direct _count modification, this patch rename it
to _refcount and add warning message on the code. After that, developer
who need to handle reference count will find that field should not be
accessed directly.
[akpm@linux-foundation.org: fix comments, per Vlastimil]
[akpm@linux-foundation.org: Documentation/vm/transhuge.txt too]
[sfr@canb.auug.org.au: sync ethernet driver changes]
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Hugh Dickins <hughd@google.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Sunil Goutham <sgoutham@cavium.com>
Cc: Chris Metcalf <cmetcalf@mellanox.com>
Cc: Manish Chopra <manish.chopra@qlogic.com>
Cc: Yuval Mintz <yuval.mintz@qlogic.com>
Cc: Tariq Toukan <tariqt@mellanox.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/page_alloc.c')
-rw-r--r-- | mm/page_alloc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index c1069efcc4d7..4ce57f938b7f 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c | |||
@@ -794,7 +794,7 @@ static inline int free_pages_check(struct page *page) | |||
794 | if (unlikely(page->mapping != NULL)) | 794 | if (unlikely(page->mapping != NULL)) |
795 | bad_reason = "non-NULL mapping"; | 795 | bad_reason = "non-NULL mapping"; |
796 | if (unlikely(page_ref_count(page) != 0)) | 796 | if (unlikely(page_ref_count(page) != 0)) |
797 | bad_reason = "nonzero _count"; | 797 | bad_reason = "nonzero _refcount"; |
798 | if (unlikely(page->flags & PAGE_FLAGS_CHECK_AT_FREE)) { | 798 | if (unlikely(page->flags & PAGE_FLAGS_CHECK_AT_FREE)) { |
799 | bad_reason = "PAGE_FLAGS_CHECK_AT_FREE flag(s) set"; | 799 | bad_reason = "PAGE_FLAGS_CHECK_AT_FREE flag(s) set"; |
800 | bad_flags = PAGE_FLAGS_CHECK_AT_FREE; | 800 | bad_flags = PAGE_FLAGS_CHECK_AT_FREE; |
@@ -6864,7 +6864,7 @@ bool has_unmovable_pages(struct zone *zone, struct page *page, int count, | |||
6864 | * We can't use page_count without pin a page | 6864 | * We can't use page_count without pin a page |
6865 | * because another CPU can free compound page. | 6865 | * because another CPU can free compound page. |
6866 | * This check already skips compound tails of THP | 6866 | * This check already skips compound tails of THP |
6867 | * because their page->_count is zero at all time. | 6867 | * because their page->_refcount is zero at all time. |
6868 | */ | 6868 | */ |
6869 | if (!page_ref_count(page)) { | 6869 | if (!page_ref_count(page)) { |
6870 | if (PageBuddy(page)) | 6870 | if (PageBuddy(page)) |