mm/migrate: new migrate mode MIGRATE_SYNC_NO_COPY

Introduce a new migration mode that allow to offload the copy to a device
DMA engine.  This changes the workflow of migration and not all
address_space migratepage callback can support this.

This is intended to be use by migrate_vma() which itself is use for thing
like HMM (see include/linux/hmm.h).

No additional per-filesystem migratepage testing is needed.  I disables
MIGRATE_SYNC_NO_COPY in all problematic migratepage() callback and i
added comment in those to explain why (part of this patch).  The commit
message is unclear it should say that any callback that wish to support
this new mode need to be aware of the difference in the migration flow
from other mode.

Some of these callbacks do extra locking while copying (aio, zsmalloc,
balloon, ...) and for DMA to be effective you want to copy multiple
pages in one DMA operations.  But in the problematic case you can not
easily hold the extra lock accross multiple call to this callback.

Usual flow is:

For each page {
 1 - lock page
 2 - call migratepage() callback
 3 - (extra locking in some migratepage() callback)
 4 - migrate page state (freeze refcount, update page cache, buffer
     head, ...)
 5 - copy page
 6 - (unlock any extra lock of migratepage() callback)
 7 - return from migratepage() callback
 8 - unlock page
}

The new mode MIGRATE_SYNC_NO_COPY:
 1 - lock multiple pages
For each page {
 2 - call migratepage() callback
 3 - abort in all problematic migratepage() callback
 4 - migrate page state (freeze refcount, update page cache, buffer
     head, ...)
} // finished all calls to migratepage() callback
 5 - DMA copy multiple pages
 6 - unlock all the pages

To support MIGRATE_SYNC_NO_COPY in the problematic case we would need a
new callback migratepages() (for instance) that deals with multiple
pages in one transaction.

Because the problematic cases are not important for current usage I did
not wanted to complexify this patchset even more for no good reason.

Link: http://lkml.kernel.org/r/20170817000548.32038-14-jglisse@redhat.com
Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
Cc: Aneesh Kumar <aneesh.kumar@linux.vnet.ibm.com>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: David Nellans <dnellans@nvidia.com>
Cc: Evgeny Baskakov <ebaskakov@nvidia.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Mark Hairgrove <mhairgrove@nvidia.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Sherry Cheung <SCheung@nvidia.com>
Cc: Subhash Gutti <sgutti@nvidia.com>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Bob Liu <liubo95@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 files changed, 40 insertions, 12 deletions

diff --git a/mm/migrate.c b/mm/migrate.c
index 1088cef6ef8b..71de36cfb673 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -634,15 +634,10 @@ static void copy_huge_page(struct page *dst, struct page *src)
 /*
  * Copy the page to its new location
  */
-void migrate_page_copy(struct page *newpage, struct page *page)
+void migrate_page_states(struct page *newpage, struct page *page)
 {
         int cpupid;
 
-        if (PageHuge(page) || PageTransHuge(page))
-                copy_huge_page(newpage, page);
-        else
-                copy_highpage(newpage, page);
-
         if (PageError(page))
                 SetPageError(newpage);
         if (PageReferenced(page))
@@ -696,6 +691,17 @@ void migrate_page_copy(struct page *newpage, struct page *page)
 
         mem_cgroup_migrate(page, newpage);
 }
+EXPORT_SYMBOL(migrate_page_states);
+
+void migrate_page_copy(struct page *newpage, struct page *page)
+{
+        if (PageHuge(page) || PageTransHuge(page))
+                copy_huge_page(newpage, page);
+        else
+                copy_highpage(newpage, page);
+
+        migrate_page_states(newpage, page);
+}
 EXPORT_SYMBOL(migrate_page_copy);
 
 /************************************************************
@@ -721,7 +727,10 @@ int migrate_page(struct address_space *mapping,
         if (rc != MIGRATEPAGE_SUCCESS)
                 return rc;
 
-        migrate_page_copy(newpage, page);
+        if (mode != MIGRATE_SYNC_NO_COPY)
+                migrate_page_copy(newpage, page);
+        else
+                migrate_page_states(newpage, page);
         return MIGRATEPAGE_SUCCESS;
 }
 EXPORT_SYMBOL(migrate_page);
@@ -771,12 +780,15 @@ int buffer_migrate_page(struct address_space *mapping,
 
         SetPagePrivate(newpage);
 
-        migrate_page_copy(newpage, page);
+        if (mode != MIGRATE_SYNC_NO_COPY)
+                migrate_page_copy(newpage, page);
+        else
+                migrate_page_states(newpage, page);
 
         bh = head;
         do {
                 unlock_buffer(bh);
-                put_bh(bh);
+                put_bh(bh);
                 bh = bh->b_this_page;
 
         } while (bh != head);
@@ -835,8 +847,13 @@ static int fallback_migrate_page(struct address_space *mapping,
 {
         if (PageDirty(page)) {
                 /* Only writeback pages in full synchronous migration */
-                if (mode != MIGRATE_SYNC)
+                switch (mode) {
+                case MIGRATE_SYNC:
+                case MIGRATE_SYNC_NO_COPY:
+                        break;
+                default:
                         return -EBUSY;
+                }
                 return writeout(mapping, page);
         }
 
@@ -973,7 +990,11 @@ static int __unmap_and_move(struct page *page, struct page *newpage,
                  * the retry loop is too short and in the sync-light case,
                  * the overhead of stalling is too much
                  */
-                if (mode != MIGRATE_SYNC) {
+                switch (mode) {
+                case MIGRATE_SYNC:
+                case MIGRATE_SYNC_NO_COPY:
+                        break;
+                default:
                         rc = -EBUSY;
                         goto out_unlock;
                 }
@@ -1243,8 +1264,15 @@ static int unmap_and_move_huge_page(new_page_t get_new_page,
                 return -ENOMEM;
 
         if (!trylock_page(hpage)) {
-                if (!force || mode != MIGRATE_SYNC)
+                if (!force)
                         goto out;
+                switch (mode) {
+                case MIGRATE_SYNC:
+                case MIGRATE_SYNC_NO_COPY:
+                        break;
+                default:
+                        goto out;
+                }
                 lock_page(hpage);
         }