Merge branch 'akpm' (patches from Andrew)

Merge updates from Andrew Morton:

 - a few hot fixes

 - ocfs2 updates

 - almost all of -mm (slab-generic, slab, slub, kmemleak, kasan,
   cleanups, debug, pagecache, memcg, gup, pagemap, memory-hotplug,
   sparsemem, vmalloc, initialization, z3fold, compaction, mempolicy,
   oom-kill, hugetlb, migration, thp, mmap, madvise, shmem, zswap,
   zsmalloc)

* emailed patches from Andrew Morton <akpm@linux-foundation.org>: (132 commits)
  mm/zsmalloc.c: fix a -Wunused-function warning
  zswap: do not map same object twice
  zswap: use movable memory if zpool support allocate movable memory
  zpool: add malloc_support_movable to zpool_driver
  shmem: fix obsolete comment in shmem_getpage_gfp()
  mm/madvise: reduce code duplication in error handling paths
  mm: mmap: increase sockets maximum memory size pgoff for 32bits
  mm/mmap.c: refine find_vma_prev() with rb_last()
  riscv: make mmap allocation top-down by default
  mips: use generic mmap top-down layout and brk randomization
  mips: replace arch specific way to determine 32bit task with generic version
  mips: adjust brk randomization offset to fit generic version
  mips: use STACK_TOP when computing mmap base address
  mips: properly account for stack randomization and stack guard gap
  arm: use generic mmap top-down layout and brk randomization
  arm: use STACK_TOP when computing mmap base address
  arm: properly account for stack randomization and stack guard gap
  arm64, mm: make randomization selected by generic topdown mmap layout
  arm64, mm: move generic mmap layout functions to mm
  arm64: consider stack randomization for mmap base only when necessary
  ...

1 files changed, 16 insertions, 36 deletions

diff --git a/mm/madvise.c b/mm/madvise.c
index 88babcc384b9..68ab988ad433 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -107,28 +107,14 @@ static long madvise_behavior(struct vm_area_struct *vma,
         case MADV_MERGEABLE:
         case MADV_UNMERGEABLE:
                 error = ksm_madvise(vma, start, end, behavior, &new_flags);
-                if (error) {
-                        /*
-                         * madvise() returns EAGAIN if kernel resources, such as
-                         * slab, are temporarily unavailable.
-                         */
-                        if (error == -ENOMEM)
-                                error = -EAGAIN;
-                        goto out;
-                }
+                if (error)
+                        goto out_convert_errno;
                 break;
         case MADV_HUGEPAGE:
         case MADV_NOHUGEPAGE:
                 error = hugepage_madvise(vma, &new_flags, behavior);
-                if (error) {
-                        /*
-                         * madvise() returns EAGAIN if kernel resources, such as
-                         * slab, are temporarily unavailable.
-                         */
-                        if (error == -ENOMEM)
-                                error = -EAGAIN;
-                        goto out;
-                }
+                if (error)
+                        goto out_convert_errno;
                 break;
         }
 
@@ -154,15 +140,8 @@ static long madvise_behavior(struct vm_area_struct *vma,
                         goto out;
                 }
                 error = __split_vma(mm, vma, start, 1);
-                if (error) {
-                        /*
-                         * madvise() returns EAGAIN if kernel resources, such as
-                         * slab, are temporarily unavailable.
-                         */
-                        if (error == -ENOMEM)
-                                error = -EAGAIN;
-                        goto out;
-                }
+                if (error)
+                        goto out_convert_errno;
         }
 
         if (end != vma->vm_end) {
@@ -171,15 +150,8 @@ static long madvise_behavior(struct vm_area_struct *vma,
                         goto out;
                 }
                 error = __split_vma(mm, vma, end, 0);
-                if (error) {
-                        /*
-                         * madvise() returns EAGAIN if kernel resources, such as
-                         * slab, are temporarily unavailable.
-                         */
-                        if (error == -ENOMEM)
-                                error = -EAGAIN;
-                        goto out;
-                }
+                if (error)
+                        goto out_convert_errno;
         }
 
 success:
@@ -187,6 +159,14 @@ success:
          * vm_flags is protected by the mmap_sem held in write mode.
          */
         vma->vm_flags = new_flags;
+
+out_convert_errno:
+        /*
+         * madvise() returns EAGAIN if kernel resources, such as
+         * slab, are temporarily unavailable.
+         */
+        if (error == -ENOMEM)
+                error = -EAGAIN;
 out:
         return error;
 }