diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2017-06-15 04:54:51 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2017-06-15 04:54:51 -0400 |
commit | 54ed0f71f0a0cbf3218e2503a50364f178b1e855 (patch) | |
tree | 6bb2b4a205bbc208311fbf46e9ed02eb05357a17 /lib | |
parent | 35e60a6b7577218ac7eb7777c8849822a080e127 (diff) | |
parent | d41519a69b35b10af7fda867fb9100df24fdf403 (diff) |
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
Pull crypto fix from Herbert Xu:
"This fixes a bug on sparc where we may dereference freed stack memory"
* 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6:
crypto: Work around deallocated stack frame reference gcc bug on sparc.
Diffstat (limited to 'lib')
-rw-r--r-- | lib/libcrc32c.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/libcrc32c.c b/lib/libcrc32c.c index 74a54b7f2562..9f79547d1b97 100644 --- a/lib/libcrc32c.c +++ b/lib/libcrc32c.c | |||
@@ -43,7 +43,7 @@ static struct crypto_shash *tfm; | |||
43 | u32 crc32c(u32 crc, const void *address, unsigned int length) | 43 | u32 crc32c(u32 crc, const void *address, unsigned int length) |
44 | { | 44 | { |
45 | SHASH_DESC_ON_STACK(shash, tfm); | 45 | SHASH_DESC_ON_STACK(shash, tfm); |
46 | u32 *ctx = (u32 *)shash_desc_ctx(shash); | 46 | u32 ret, *ctx = (u32 *)shash_desc_ctx(shash); |
47 | int err; | 47 | int err; |
48 | 48 | ||
49 | shash->tfm = tfm; | 49 | shash->tfm = tfm; |
@@ -53,7 +53,9 @@ u32 crc32c(u32 crc, const void *address, unsigned int length) | |||
53 | err = crypto_shash_update(shash, address, length); | 53 | err = crypto_shash_update(shash, address, length); |
54 | BUG_ON(err); | 54 | BUG_ON(err); |
55 | 55 | ||
56 | return *ctx; | 56 | ret = *ctx; |
57 | barrier_data(ctx); | ||
58 | return ret; | ||
57 | } | 59 | } |
58 | 60 | ||
59 | EXPORT_SYMBOL(crc32c); | 61 | EXPORT_SYMBOL(crc32c); |