diff options
author | Joe Perches <joe@perches.com> | 2017-12-19 13:15:07 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-01-09 10:33:31 -0500 |
commit | b6b996b6cdeecf7e1646c87422e04e446ddce124 (patch) | |
tree | ef1b873db80200b159624ce2611137024abf1672 /lib/test_kmod.c | |
parent | 353c6ddaa963d453dc56ced2f3cbfd9bd57409c7 (diff) |
treewide: Use DEVICE_ATTR_RW
Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
Done with perl script:
$ git grep -w --name-only DEVICE_ATTR | \
xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(\s*S_IRUGO\s*\|\s*S_IWUSR|\s*S_IWUSR\s*\|\s*S_IRUGO\s*|\s*0644\s*)\)?\s*,\s*\1_show\s*,\s*\1_store\s*\)/DEVICE_ATTR_RW(\1)/g; print;}'
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/test_kmod.c')
-rw-r--r-- | lib/test_kmod.c | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/lib/test_kmod.c b/lib/test_kmod.c index 337f408b4de6..e372b97eee13 100644 --- a/lib/test_kmod.c +++ b/lib/test_kmod.c | |||
@@ -694,8 +694,7 @@ static ssize_t config_test_driver_show(struct device *dev, | |||
694 | return config_test_show_str(&test_dev->config_mutex, buf, | 694 | return config_test_show_str(&test_dev->config_mutex, buf, |
695 | config->test_driver); | 695 | config->test_driver); |
696 | } | 696 | } |
697 | static DEVICE_ATTR(config_test_driver, 0644, config_test_driver_show, | 697 | static DEVICE_ATTR_RW(config_test_driver); |
698 | config_test_driver_store); | ||
699 | 698 | ||
700 | static ssize_t config_test_fs_store(struct device *dev, | 699 | static ssize_t config_test_fs_store(struct device *dev, |
701 | struct device_attribute *attr, | 700 | struct device_attribute *attr, |
@@ -726,8 +725,7 @@ static ssize_t config_test_fs_show(struct device *dev, | |||
726 | return config_test_show_str(&test_dev->config_mutex, buf, | 725 | return config_test_show_str(&test_dev->config_mutex, buf, |
727 | config->test_fs); | 726 | config->test_fs); |
728 | } | 727 | } |
729 | static DEVICE_ATTR(config_test_fs, 0644, config_test_fs_show, | 728 | static DEVICE_ATTR_RW(config_test_fs); |
730 | config_test_fs_store); | ||
731 | 729 | ||
732 | static int trigger_config_run_type(struct kmod_test_device *test_dev, | 730 | static int trigger_config_run_type(struct kmod_test_device *test_dev, |
733 | enum kmod_test_case test_case, | 731 | enum kmod_test_case test_case, |
@@ -1012,8 +1010,7 @@ static ssize_t config_num_threads_show(struct device *dev, | |||
1012 | 1010 | ||
1013 | return test_dev_config_show_int(test_dev, buf, config->num_threads); | 1011 | return test_dev_config_show_int(test_dev, buf, config->num_threads); |
1014 | } | 1012 | } |
1015 | static DEVICE_ATTR(config_num_threads, 0644, config_num_threads_show, | 1013 | static DEVICE_ATTR_RW(config_num_threads); |
1016 | config_num_threads_store); | ||
1017 | 1014 | ||
1018 | static ssize_t config_test_case_store(struct device *dev, | 1015 | static ssize_t config_test_case_store(struct device *dev, |
1019 | struct device_attribute *attr, | 1016 | struct device_attribute *attr, |
@@ -1037,8 +1034,7 @@ static ssize_t config_test_case_show(struct device *dev, | |||
1037 | 1034 | ||
1038 | return test_dev_config_show_uint(test_dev, buf, config->test_case); | 1035 | return test_dev_config_show_uint(test_dev, buf, config->test_case); |
1039 | } | 1036 | } |
1040 | static DEVICE_ATTR(config_test_case, 0644, config_test_case_show, | 1037 | static DEVICE_ATTR_RW(config_test_case); |
1041 | config_test_case_store); | ||
1042 | 1038 | ||
1043 | static ssize_t test_result_show(struct device *dev, | 1039 | static ssize_t test_result_show(struct device *dev, |
1044 | struct device_attribute *attr, | 1040 | struct device_attribute *attr, |
@@ -1049,7 +1045,7 @@ static ssize_t test_result_show(struct device *dev, | |||
1049 | 1045 | ||
1050 | return test_dev_config_show_int(test_dev, buf, config->test_result); | 1046 | return test_dev_config_show_int(test_dev, buf, config->test_result); |
1051 | } | 1047 | } |
1052 | static DEVICE_ATTR(test_result, 0644, test_result_show, test_result_store); | 1048 | static DEVICE_ATTR_RW(test_result); |
1053 | 1049 | ||
1054 | #define TEST_KMOD_DEV_ATTR(name) &dev_attr_##name.attr | 1050 | #define TEST_KMOD_DEV_ATTR(name) &dev_attr_##name.attr |
1055 | 1051 | ||