diff options
author | Nikolay Borisov <nborisov@suse.com> | 2017-06-20 14:01:20 -0400 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2017-06-20 15:42:32 -0400 |
commit | 104b4e5139fe384431ac11c3b8a6cf4a529edf4a (patch) | |
tree | e8a0157f2294f006f31e535949327b3484a5dcb8 /lib/percpu_counter.c | |
parent | df95e795a722892a9e0603ce4b9b62fab9f02967 (diff) |
percpu_counter: Rename __percpu_counter_add to percpu_counter_add_batch
Currently, percpu_counter_add is a wrapper around __percpu_counter_add
which is preempt safe due to explicit calls to preempt_disable. Given
how __ prefix is used in percpu related interfaces, the naming
unfortunately creates the false sense that __percpu_counter_add is
less safe than percpu_counter_add. In terms of context-safety,
they're equivalent. The only difference is that the __ version takes
a batch parameter.
Make this a bit more explicit by just renaming __percpu_counter_add to
percpu_counter_add_batch.
This patch doesn't cause any functional changes.
tj: Minor updates to patch description for clarity. Cosmetic
indentation updates.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Chris Mason <clm@fb.com>
Cc: Josef Bacik <jbacik@fb.com>
Cc: David Sterba <dsterba@suse.com>
Cc: Darrick J. Wong <darrick.wong@oracle.com>
Cc: Jan Kara <jack@suse.com>
Cc: Jens Axboe <axboe@fb.com>
Cc: linux-mm@kvack.org
Cc: "David S. Miller" <davem@davemloft.net>
Diffstat (limited to 'lib/percpu_counter.c')
-rw-r--r-- | lib/percpu_counter.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/percpu_counter.c b/lib/percpu_counter.c index 9c21000df0b5..8ee7e5ec21be 100644 --- a/lib/percpu_counter.c +++ b/lib/percpu_counter.c | |||
@@ -72,7 +72,7 @@ void percpu_counter_set(struct percpu_counter *fbc, s64 amount) | |||
72 | } | 72 | } |
73 | EXPORT_SYMBOL(percpu_counter_set); | 73 | EXPORT_SYMBOL(percpu_counter_set); |
74 | 74 | ||
75 | void __percpu_counter_add(struct percpu_counter *fbc, s64 amount, s32 batch) | 75 | void percpu_counter_add_batch(struct percpu_counter *fbc, s64 amount, s32 batch) |
76 | { | 76 | { |
77 | s64 count; | 77 | s64 count; |
78 | 78 | ||
@@ -89,7 +89,7 @@ void __percpu_counter_add(struct percpu_counter *fbc, s64 amount, s32 batch) | |||
89 | } | 89 | } |
90 | preempt_enable(); | 90 | preempt_enable(); |
91 | } | 91 | } |
92 | EXPORT_SYMBOL(__percpu_counter_add); | 92 | EXPORT_SYMBOL(percpu_counter_add_batch); |
93 | 93 | ||
94 | /* | 94 | /* |
95 | * Add up all the per-cpu counts, return the result. This is a more accurate | 95 | * Add up all the per-cpu counts, return the result. This is a more accurate |