diff options
author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-01-25 15:46:46 -0500 |
---|---|---|
committer | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-04-08 19:39:28 -0400 |
commit | afb33e40d54e365457a4fb5eada6df55cd11a9cf (patch) | |
tree | d819a43110f20c724efb8d8e67d8d96153361630 /lib/asn1_decoder.c | |
parent | 8a05452ca460b05c985eadc7b5a4f040f124463e (diff) |
ASN.1: mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warnings:
lib/asn1_decoder.c:386:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
lib/asn1_decoder.c:449:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough.
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Diffstat (limited to 'lib/asn1_decoder.c')
-rw-r--r-- | lib/asn1_decoder.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/asn1_decoder.c b/lib/asn1_decoder.c index dc14beae2c9a..8f3d207d2b00 100644 --- a/lib/asn1_decoder.c +++ b/lib/asn1_decoder.c | |||
@@ -385,6 +385,8 @@ next_op: | |||
385 | case ASN1_OP_END_SET_ACT: | 385 | case ASN1_OP_END_SET_ACT: |
386 | if (unlikely(!(flags & FLAG_MATCHED))) | 386 | if (unlikely(!(flags & FLAG_MATCHED))) |
387 | goto tag_mismatch; | 387 | goto tag_mismatch; |
388 | /* fall through */ | ||
389 | |||
388 | case ASN1_OP_END_SEQ: | 390 | case ASN1_OP_END_SEQ: |
389 | case ASN1_OP_END_SET_OF: | 391 | case ASN1_OP_END_SET_OF: |
390 | case ASN1_OP_END_SEQ_OF: | 392 | case ASN1_OP_END_SEQ_OF: |
@@ -450,6 +452,8 @@ next_op: | |||
450 | pc += asn1_op_lengths[op]; | 452 | pc += asn1_op_lengths[op]; |
451 | goto next_op; | 453 | goto next_op; |
452 | } | 454 | } |
455 | /* fall through */ | ||
456 | |||
453 | case ASN1_OP_ACT: | 457 | case ASN1_OP_ACT: |
454 | ret = actions[machine[pc + 1]](context, hdr, tag, data + tdp, len); | 458 | ret = actions[machine[pc + 1]](context, hdr, tag, data + tdp, len); |
455 | if (ret < 0) | 459 | if (ret < 0) |