diff options
author | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2017-10-09 14:30:11 -0400 |
---|---|---|
committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2017-12-04 13:52:56 -0500 |
commit | 243d1a7977ae0814aa1ccb8bb87f8a4e0822ca8f (patch) | |
tree | 06f7f98bf99d03b748bb85f12290c98c57558c57 /kernel/tracepoint.c | |
parent | 548095dea63ffc016d39c35b32c628d033638aca (diff) |
tracepoint: Remove smp_read_barrier_depends() from comment
The comment in tracepoint_add_func() mentions smp_read_barrier_depends(),
whose use should be quite restricted. This commit updates the comment
to instead mention the smp_store_release() and rcu_dereference_sched()
that the current code actually uses.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Diffstat (limited to 'kernel/tracepoint.c')
-rw-r--r-- | kernel/tracepoint.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c index 685c50ae6300..671b13457387 100644 --- a/kernel/tracepoint.c +++ b/kernel/tracepoint.c | |||
@@ -212,11 +212,10 @@ static int tracepoint_add_func(struct tracepoint *tp, | |||
212 | } | 212 | } |
213 | 213 | ||
214 | /* | 214 | /* |
215 | * rcu_assign_pointer has a smp_wmb() which makes sure that the new | 215 | * rcu_assign_pointer has as smp_store_release() which makes sure |
216 | * probe callbacks array is consistent before setting a pointer to it. | 216 | * that the new probe callbacks array is consistent before setting |
217 | * This array is referenced by __DO_TRACE from | 217 | * a pointer to it. This array is referenced by __DO_TRACE from |
218 | * include/linux/tracepoints.h. A matching smp_read_barrier_depends() | 218 | * include/linux/tracepoint.h using rcu_dereference_sched(). |
219 | * is used. | ||
220 | */ | 219 | */ |
221 | rcu_assign_pointer(tp->funcs, tp_funcs); | 220 | rcu_assign_pointer(tp->funcs, tp_funcs); |
222 | if (!static_key_enabled(&tp->key)) | 221 | if (!static_key_enabled(&tp->key)) |