summaryrefslogtreecommitdiffstats
path: root/kernel/printk
diff options
context:
space:
mode:
authorAleksey Makarov <aleksey.makarov@linaro.org>2017-03-15 06:28:51 -0400
committerPetr Mladek <pmladek@suse.com>2017-04-12 05:40:19 -0400
commitad86ee2b8a47590f62a4f3bc1d25dc126d121cb9 (patch)
treea95f53b7951a69f160a0c79b0b93d9448b560efa /kernel/printk
parentb077bafa2f3848ddfcef2ef3a4a61a867f9113b5 (diff)
printk: rename selected_console -> preferred_console
The variable selected_console is set in __add_preferred_console() to point to the last console parameter that was added to the console_cmdline array. Rename it to preferred_console so that the name reflects the usage. Petr Mladek: "[..] the selected_console/preferred_console value is used to keep the console first in the console_drivers list. IMHO, the main effect is that each line will first appear on this console, see call_console_drivers(). But the message will still appear also on all other enabled consoles. From this point, the name "preferred" sounds better to me. More consoles are selected (enabled) and only one is preferred (first)." Link: http://lkml.kernel.org/r/20170315102854.1763-3-aleksey.makarov@linaro.org Cc: Sudeep Holla <sudeep.holla@arm.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jslaby@suse.com> Cc: Robin Murphy <robin.murphy@arm.com> Cc: "Nair, Jayachandran" <Jayachandran.Nair@cavium.com> Cc: linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Aleksey Makarov <aleksey.makarov@linaro.org> Suggested-by: Peter Hurley <peter@hurleysoftware.com> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Signed-off-by: Petr Mladek <pmladek@suse.com>
Diffstat (limited to 'kernel/printk')
-rw-r--r--kernel/printk/printk.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 1afc2d69b21f..82927ca04849 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -267,7 +267,7 @@ static struct console *exclusive_console;
267 267
268static struct console_cmdline console_cmdline[MAX_CMDLINECONSOLES]; 268static struct console_cmdline console_cmdline[MAX_CMDLINECONSOLES];
269 269
270static int selected_console = -1; 270static int preferred_console = -1;
271int console_set_on_cmdline; 271int console_set_on_cmdline;
272EXPORT_SYMBOL(console_set_on_cmdline); 272EXPORT_SYMBOL(console_set_on_cmdline);
273 273
@@ -1907,14 +1907,14 @@ static int __add_preferred_console(char *name, int idx, char *options,
1907 i++, c++) { 1907 i++, c++) {
1908 if (strcmp(c->name, name) == 0 && c->index == idx) { 1908 if (strcmp(c->name, name) == 0 && c->index == idx) {
1909 if (!brl_options) 1909 if (!brl_options)
1910 selected_console = i; 1910 preferred_console = i;
1911 return 0; 1911 return 0;
1912 } 1912 }
1913 } 1913 }
1914 if (i == MAX_CMDLINECONSOLES) 1914 if (i == MAX_CMDLINECONSOLES)
1915 return -E2BIG; 1915 return -E2BIG;
1916 if (!brl_options) 1916 if (!brl_options)
1917 selected_console = i; 1917 preferred_console = i;
1918 strlcpy(c->name, name, sizeof(c->name)); 1918 strlcpy(c->name, name, sizeof(c->name));
1919 c->options = options; 1919 c->options = options;
1920 braille_set_options(c, brl_options); 1920 braille_set_options(c, brl_options);
@@ -2438,7 +2438,7 @@ void register_console(struct console *newcon)
2438 bcon = console_drivers; 2438 bcon = console_drivers;
2439 2439
2440 if (!has_preferred || bcon || !console_drivers) 2440 if (!has_preferred || bcon || !console_drivers)
2441 has_preferred = selected_console >= 0; 2441 has_preferred = preferred_console >= 0;
2442 2442
2443 /* 2443 /*
2444 * See if we want to use this console driver. If we 2444 * See if we want to use this console driver. If we
@@ -2486,7 +2486,7 @@ void register_console(struct console *newcon)
2486 } 2486 }
2487 2487
2488 newcon->flags |= CON_ENABLED; 2488 newcon->flags |= CON_ENABLED;
2489 if (i == selected_console) { 2489 if (i == preferred_console) {
2490 newcon->flags |= CON_CONSDEV; 2490 newcon->flags |= CON_CONSDEV;
2491 has_preferred = true; 2491 has_preferred = true;
2492 } 2492 }