Merge tag 'driver-core-5.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core

Pull driver core and debugfs updates from Greg KH:
 "Here is the "big" driver core and debugfs changes for 5.3-rc1

  It's a lot of different patches, all across the tree due to some api
  changes and lots of debugfs cleanups.

  Other than the debugfs cleanups, in this set of changes we have:

   - bus iteration function cleanups

   - scripts/get_abi.pl tool to display and parse Documentation/ABI
     entries in a simple way

   - cleanups to Documenatation/ABI/ entries to make them parse easier
     due to typos and other minor things

   - default_attrs use for some ktype users

   - driver model documentation file conversions to .rst

   - compressed firmware file loading

   - deferred probe fixes

  All of these have been in linux-next for a while, with a bunch of
  merge issues that Stephen has been patient with me for"

* tag 'driver-core-5.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core: (102 commits)
  debugfs: make error message a bit more verbose
  orangefs: fix build warning from debugfs cleanup patch
  ubifs: fix build warning after debugfs cleanup patch
  driver: core: Allow subsystems to continue deferring probe
  drivers: base: cacheinfo: Ensure cpu hotplug work is done before Intel RDT
  arch_topology: Remove error messages on out-of-memory conditions
  lib: notifier-error-inject: no need to check return value of debugfs_create functions
  swiotlb: no need to check return value of debugfs_create functions
  ceph: no need to check return value of debugfs_create functions
  sunrpc: no need to check return value of debugfs_create functions
  ubifs: no need to check return value of debugfs_create functions
  orangefs: no need to check return value of debugfs_create functions
  nfsd: no need to check return value of debugfs_create functions
  lib: 842: no need to check return value of debugfs_create functions
  debugfs: provide pr_fmt() macro
  debugfs: log errors when something goes wrong
  drivers: s390/cio: Fix compilation warning about const qualifiers
  drivers: Add generic helper to match by of_node
  driver_find_device: Unify the match function with class_find_device()
  bus_find_device: Unify the match callback with class_find_device
  ...

1 files changed, 5 insertions, 18 deletions

diff --git a/kernel/fail_function.c b/kernel/fail_function.c
index feb80712b913..63b349168da7 100644
--- a/kernel/fail_function.c
+++ b/kernel/fail_function.c
@@ -152,20 +152,13 @@ static int fei_retval_get(void *data, u64 *val)
 DEFINE_DEBUGFS_ATTRIBUTE(fei_retval_ops, fei_retval_get, fei_retval_set,
                          "%llx\n");
 
-static int fei_debugfs_add_attr(struct fei_attr *attr)
+static void fei_debugfs_add_attr(struct fei_attr *attr)
 {
         struct dentry *dir;
 
         dir = debugfs_create_dir(attr->kp.symbol_name, fei_debugfs_dir);
-        if (!dir)
-                return -ENOMEM;
-
-        if (!debugfs_create_file("retval", 0600, dir, attr, &fei_retval_ops)) {
-                debugfs_remove_recursive(dir);
-                return -ENOMEM;
-        }
 
-        return 0;
+        debugfs_create_file("retval", 0600, dir, attr, &fei_retval_ops);
 }
 
 static void fei_debugfs_remove_attr(struct fei_attr *attr)
@@ -306,7 +299,7 @@ static ssize_t fei_write(struct file *file, const char __user *buffer,
 
         ret = register_kprobe(&attr->kp);
         if (!ret)
-                ret = fei_debugfs_add_attr(attr);
+                fei_debugfs_add_attr(attr);
         if (ret < 0)
                 fei_attr_remove(attr);
         else {
@@ -337,19 +330,13 @@ static int __init fei_debugfs_init(void)
                 return PTR_ERR(dir);
 
         /* injectable attribute is just a symlink of error_inject/list */
-        if (!debugfs_create_symlink("injectable", dir,
-                                    "../error_injection/list"))
-                goto error;
+        debugfs_create_symlink("injectable", dir, "../error_injection/list");
 
-        if (!debugfs_create_file("inject", 0600, dir, NULL, &fei_ops))
-                goto error;
+        debugfs_create_file("inject", 0600, dir, NULL, &fei_ops);
 
         fei_debugfs_dir = dir;
 
         return 0;
-error:
-        debugfs_remove_recursive(dir);
-        return -ENOMEM;
 }
 
 late_initcall(fei_debugfs_init);