diff options
author | Mark Brown <broonie@kernel.org> | 2019-01-23 12:29:53 -0500 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2019-01-23 12:29:53 -0500 |
commit | f0125f1a559be1033055f44e511174aaa75b60cc (patch) | |
tree | 83d67533a010578ce2bc018302fc5ec2e291c9a4 /include/linux/spi | |
parent | 51eea52d26d4939b788b7244c28cf47e902b4c4c (diff) |
spi: Go back to immediate teardown
Commit 412e6037324 ("spi: core: avoid waking pump thread from spi_sync
instead run teardown delayed") introduced regressions on some boards,
apparently connected to spi_mem not triggering shutdown properly any
more. Since we've thus far been unable to figure out exactly where the
breakage is revert the optimisation for now.
Reported-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: kernel@martin.sperl.org
Diffstat (limited to 'include/linux/spi')
-rw-r--r-- | include/linux/spi/spi.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index 79ad62e2487c..916bba47d156 100644 --- a/include/linux/spi/spi.h +++ b/include/linux/spi/spi.h | |||
@@ -334,7 +334,6 @@ static inline void spi_unregister_driver(struct spi_driver *sdrv) | |||
334 | * @kworker: thread struct for message pump | 334 | * @kworker: thread struct for message pump |
335 | * @kworker_task: pointer to task for message pump kworker thread | 335 | * @kworker_task: pointer to task for message pump kworker thread |
336 | * @pump_messages: work struct for scheduling work to the message pump | 336 | * @pump_messages: work struct for scheduling work to the message pump |
337 | * @pump_idle_teardown: work structure for scheduling a teardown delayed | ||
338 | * @queue_lock: spinlock to syncronise access to message queue | 337 | * @queue_lock: spinlock to syncronise access to message queue |
339 | * @queue: message queue | 338 | * @queue: message queue |
340 | * @idling: the device is entering idle state | 339 | * @idling: the device is entering idle state |
@@ -533,7 +532,6 @@ struct spi_controller { | |||
533 | struct kthread_worker kworker; | 532 | struct kthread_worker kworker; |
534 | struct task_struct *kworker_task; | 533 | struct task_struct *kworker_task; |
535 | struct kthread_work pump_messages; | 534 | struct kthread_work pump_messages; |
536 | struct kthread_delayed_work pump_idle_teardown; | ||
537 | spinlock_t queue_lock; | 535 | spinlock_t queue_lock; |
538 | struct list_head queue; | 536 | struct list_head queue; |
539 | struct spi_message *cur_msg; | 537 | struct spi_message *cur_msg; |