diff options
author | Will Deacon <will.deacon@arm.com> | 2017-10-24 06:22:48 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2017-10-24 07:17:33 -0400 |
commit | 506458efaf153c1ea480591c5602a5a3ba5a3b76 (patch) | |
tree | c4ac0a89bf23993036720ec8883fff0740bf9019 /include/linux/rcupdate.h | |
parent | 76ebbe78f7390aee075a7f3768af197ded1bdfbb (diff) |
locking/barriers: Convert users of lockless_dereference() to READ_ONCE()
READ_ONCE() now has an implicit smp_read_barrier_depends() call, so it
can be used instead of lockless_dereference() without any change in
semantics.
Signed-off-by: Will Deacon <will.deacon@arm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1508840570-22169-4-git-send-email-will.deacon@arm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'include/linux/rcupdate.h')
-rw-r--r-- | include/linux/rcupdate.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h index 1a9f70d44af9..a6ddc42f87a5 100644 --- a/include/linux/rcupdate.h +++ b/include/linux/rcupdate.h | |||
@@ -346,7 +346,7 @@ static inline void rcu_preempt_sleep_check(void) { } | |||
346 | #define __rcu_dereference_check(p, c, space) \ | 346 | #define __rcu_dereference_check(p, c, space) \ |
347 | ({ \ | 347 | ({ \ |
348 | /* Dependency order vs. p above. */ \ | 348 | /* Dependency order vs. p above. */ \ |
349 | typeof(*p) *________p1 = (typeof(*p) *__force)lockless_dereference(p); \ | 349 | typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \ |
350 | RCU_LOCKDEP_WARN(!(c), "suspicious rcu_dereference_check() usage"); \ | 350 | RCU_LOCKDEP_WARN(!(c), "suspicious rcu_dereference_check() usage"); \ |
351 | rcu_dereference_sparse(p, space); \ | 351 | rcu_dereference_sparse(p, space); \ |
352 | ((typeof(*p) __force __kernel *)(________p1)); \ | 352 | ((typeof(*p) __force __kernel *)(________p1)); \ |
@@ -360,7 +360,7 @@ static inline void rcu_preempt_sleep_check(void) { } | |||
360 | #define rcu_dereference_raw(p) \ | 360 | #define rcu_dereference_raw(p) \ |
361 | ({ \ | 361 | ({ \ |
362 | /* Dependency order vs. p above. */ \ | 362 | /* Dependency order vs. p above. */ \ |
363 | typeof(p) ________p1 = lockless_dereference(p); \ | 363 | typeof(p) ________p1 = READ_ONCE(p); \ |
364 | ((typeof(*p) __force __kernel *)(________p1)); \ | 364 | ((typeof(*p) __force __kernel *)(________p1)); \ |
365 | }) | 365 | }) |
366 | 366 | ||