summaryrefslogtreecommitdiffstats
path: root/include/linux/of.h
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2018-08-27 04:21:45 -0400
committerRob Herring <robh@kernel.org>2018-08-29 09:06:46 -0400
commit36156f9241cb0f9e37d998052873ca7501ad4b36 (patch)
tree203d1e52a9e5a942a2b99ae0ecb984fa87453df8 /include/linux/of.h
parent5b394b2ddf0347bef56e50c69a58773c94343ff3 (diff)
of: add helper to lookup compatible child node
Add of_get_compatible_child() helper that can be used to lookup compatible child nodes. Several drivers currently use of_find_compatible_node() to lookup child nodes while failing to notice that the of_find_ functions search the entire tree depth-first (from a given start node) and therefore can match unrelated nodes. The fact that these functions also drop a reference to the node they start searching from (e.g. the parent node) is typically also overlooked, something which can lead to use-after-free bugs. Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'include/linux/of.h')
-rw-r--r--include/linux/of.h8
1 files changed, 8 insertions, 0 deletions
diff --git a/include/linux/of.h b/include/linux/of.h
index 4d25e4f952d9..b99a1a8c2952 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -290,6 +290,8 @@ extern struct device_node *of_get_next_child(const struct device_node *node,
290extern struct device_node *of_get_next_available_child( 290extern struct device_node *of_get_next_available_child(
291 const struct device_node *node, struct device_node *prev); 291 const struct device_node *node, struct device_node *prev);
292 292
293extern struct device_node *of_get_compatible_child(const struct device_node *parent,
294 const char *compatible);
293extern struct device_node *of_get_child_by_name(const struct device_node *node, 295extern struct device_node *of_get_child_by_name(const struct device_node *node,
294 const char *name); 296 const char *name);
295 297
@@ -632,6 +634,12 @@ static inline bool of_have_populated_dt(void)
632 return false; 634 return false;
633} 635}
634 636
637static inline struct device_node *of_get_compatible_child(const struct device_node *parent,
638 const char *compatible)
639{
640 return NULL;
641}
642
635static inline struct device_node *of_get_child_by_name( 643static inline struct device_node *of_get_child_by_name(
636 const struct device_node *node, 644 const struct device_node *node,
637 const char *name) 645 const char *name)