diff options
author | Anton Vorontsov <anton.vorontsov@linaro.org> | 2012-09-24 17:27:50 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-09-26 16:42:25 -0400 |
commit | 5a14fead07bcf4e0acc877a8d9e1d1f40a441153 (patch) | |
tree | 7fd90cf9cdd0b734f013df6bb86f34fdd80c5732 /include/linux/kgdb.h | |
parent | c5dd553b9fd069892c9e2de734f4f604e280fa7a (diff) |
kernel/debug: Mask KGDB NMI upon entry
The new arch callback should manage NMIs that usually cause KGDB to
enter. That is, not all NMIs should be enabled/disabled, but only
those that issue kgdb_handle_exception().
We must mask it as serial-line interrupt can be used as an NMI, so
if the original KGDB-entry cause was say a breakpoint, then every
input to KDB console will cause KGDB to reenter, which we don't want.
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Acked-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/kgdb.h')
-rw-r--r-- | include/linux/kgdb.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h index c4d2fc194ede..7800cce284db 100644 --- a/include/linux/kgdb.h +++ b/include/linux/kgdb.h | |||
@@ -240,6 +240,7 @@ extern void kgdb_arch_late(void); | |||
240 | * hardware breakpoints. | 240 | * hardware breakpoints. |
241 | * @correct_hw_break: Allow an architecture to specify how to correct the | 241 | * @correct_hw_break: Allow an architecture to specify how to correct the |
242 | * hardware debug registers. | 242 | * hardware debug registers. |
243 | * @enable_nmi: Manage NMI-triggered entry to KGDB | ||
243 | */ | 244 | */ |
244 | struct kgdb_arch { | 245 | struct kgdb_arch { |
245 | unsigned char gdb_bpt_instr[BREAK_INSTR_SIZE]; | 246 | unsigned char gdb_bpt_instr[BREAK_INSTR_SIZE]; |
@@ -252,6 +253,8 @@ struct kgdb_arch { | |||
252 | void (*disable_hw_break)(struct pt_regs *regs); | 253 | void (*disable_hw_break)(struct pt_regs *regs); |
253 | void (*remove_all_hw_break)(void); | 254 | void (*remove_all_hw_break)(void); |
254 | void (*correct_hw_break)(void); | 255 | void (*correct_hw_break)(void); |
256 | |||
257 | void (*enable_nmi)(bool on); | ||
255 | }; | 258 | }; |
256 | 259 | ||
257 | /** | 260 | /** |