diff options
author | Denys Vlasenko <dvlasenk@redhat.com> | 2015-08-04 10:15:16 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2015-08-05 03:38:09 -0400 |
commit | accd0b9ec015d611eb7783dd86f1bb31bf8d62ab (patch) | |
tree | f914dca60e0d68cab6b30e389c633592a90615d0 /include/linux/jiffies.h | |
parent | d14edb1648221e59fc9fd47127fcc57bf26d759f (diff) |
jiffies: Force inlining of {m,u}msecs_to_jiffies()
With this config:
http://busybox.net/~vda/kernel_config_OPTIMIZE_INLINING_and_Os
gcc-4.7.2 generates many copies of these tiny functions:
msecs_to_jiffies (45 copies):
55 push %rbp
48 89 e5 mov %rsp,%rbp
e8 59 ec 03 00 callq __msecs_to_jiffies
5d pop %rbp
c3 retq
usecs_to_jiffies (10 copies):
55 push %rbp
48 89 e5 mov %rsp,%rbp
e8 5d 54 5e ff callq __usecs_to_jiffies
5d pop %rbp
c3 retq
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66122
This patch fixes this via s/inline/__always_inline/
text data bss dec filename
86970954 17195912 36659200 140826066 vmlinux.before
86966150 17195912 36659200 140821262 vmlinux
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Thomas Graf <tgraf@suug.ch>
Cc: linux-kernel@vger.kernel.org
Link: http://lkml.kernel.org/r/1438697716-28121-3-git-send-email-dvlasenk@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'include/linux/jiffies.h')
-rw-r--r-- | include/linux/jiffies.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h index 535fd3bb1ba8..1ba48a18c1d7 100644 --- a/include/linux/jiffies.h +++ b/include/linux/jiffies.h | |||
@@ -351,7 +351,7 @@ static inline unsigned long _msecs_to_jiffies(const unsigned int m) | |||
351 | * directly here and from __msecs_to_jiffies() in the case where | 351 | * directly here and from __msecs_to_jiffies() in the case where |
352 | * constant folding is not possible. | 352 | * constant folding is not possible. |
353 | */ | 353 | */ |
354 | static inline unsigned long msecs_to_jiffies(const unsigned int m) | 354 | static __always_inline unsigned long msecs_to_jiffies(const unsigned int m) |
355 | { | 355 | { |
356 | if (__builtin_constant_p(m)) { | 356 | if (__builtin_constant_p(m)) { |
357 | if ((int)m < 0) | 357 | if ((int)m < 0) |
@@ -405,7 +405,7 @@ static inline unsigned long _usecs_to_jiffies(const unsigned int u) | |||
405 | * directly here and from __msecs_to_jiffies() in the case where | 405 | * directly here and from __msecs_to_jiffies() in the case where |
406 | * constant folding is not possible. | 406 | * constant folding is not possible. |
407 | */ | 407 | */ |
408 | static inline unsigned long usecs_to_jiffies(const unsigned int u) | 408 | static __always_inline unsigned long usecs_to_jiffies(const unsigned int u) |
409 | { | 409 | { |
410 | if (__builtin_constant_p(u)) { | 410 | if (__builtin_constant_p(u)) { |
411 | if (u > jiffies_to_usecs(MAX_JIFFY_OFFSET)) | 411 | if (u > jiffies_to_usecs(MAX_JIFFY_OFFSET)) |