diff options
author | Reshetova, Elena <elena.reshetova@intel.com> | 2017-06-30 06:08:02 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-07-01 10:39:08 -0400 |
commit | 8851ab526791530d00bbbd0952512d68684a44b8 (patch) | |
tree | 243643b2d0b72bed9947ec525be6f6142e2b6840 /include/linux/igmp.h | |
parent | 41c6d650f6537e55a1b53438c646fbc3f49176bf (diff) |
net: convert ip_mc_list.refcnt from atomic_t to refcount_t
refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free
situations.
Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David Windsor <dwindsor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/igmp.h')
-rw-r--r-- | include/linux/igmp.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/linux/igmp.h b/include/linux/igmp.h index 12f6fba6d21a..97caf1821de8 100644 --- a/include/linux/igmp.h +++ b/include/linux/igmp.h | |||
@@ -18,6 +18,7 @@ | |||
18 | #include <linux/skbuff.h> | 18 | #include <linux/skbuff.h> |
19 | #include <linux/timer.h> | 19 | #include <linux/timer.h> |
20 | #include <linux/in.h> | 20 | #include <linux/in.h> |
21 | #include <linux/refcount.h> | ||
21 | #include <uapi/linux/igmp.h> | 22 | #include <uapi/linux/igmp.h> |
22 | 23 | ||
23 | static inline struct igmphdr *igmp_hdr(const struct sk_buff *skb) | 24 | static inline struct igmphdr *igmp_hdr(const struct sk_buff *skb) |
@@ -84,7 +85,7 @@ struct ip_mc_list { | |||
84 | struct ip_mc_list __rcu *next_hash; | 85 | struct ip_mc_list __rcu *next_hash; |
85 | struct timer_list timer; | 86 | struct timer_list timer; |
86 | int users; | 87 | int users; |
87 | atomic_t refcnt; | 88 | refcount_t refcnt; |
88 | spinlock_t lock; | 89 | spinlock_t lock; |
89 | char tm_running; | 90 | char tm_running; |
90 | char reporter; | 91 | char reporter; |