summaryrefslogtreecommitdiffstats
path: root/include/linux/fs.h
diff options
context:
space:
mode:
authorDavid Howells <dhowells@redhat.com>2018-04-09 16:12:30 -0400
committerDavid Howells <dhowells@redhat.com>2018-04-09 16:12:30 -0400
commita09acf4b43b90581bf53b0c03cc84ed693bf27e2 (patch)
treef163127df6aa23ca8440b8ba19ccb4e04a8596de /include/linux/fs.h
parentfd3b36d275660c905da9900b078eea341847d5e4 (diff)
vfs: Remove the const from dir_context::actor
Remove the const marking from the actor function pointer in the dir_context struct. The const prevents the structure from being used as part of a kmalloc'd object as it makes the compiler require that the actor member be set at object initialisation time (or not at all), incuring something like the following error if you try and set it later: fs/afs/dir.c:556:20: error: assignment of read-only member 'actor' Marking the member const like this adds very little in the way of sanity checking as the type checking system is likely to provide sufficient - and if not, the kernel is very likely to oops repeatably in this case. Fixes: ac6614b76478 ("[readdir] constify ->actor") Signed-off-by: David Howells <dhowells@redhat.com> Reviewed-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'include/linux/fs.h')
-rw-r--r--include/linux/fs.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 1ee7f592e239..3a5c19d9f651 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1667,7 +1667,7 @@ typedef int (*filldir_t)(struct dir_context *, const char *, int, loff_t, u64,
1667 unsigned); 1667 unsigned);
1668 1668
1669struct dir_context { 1669struct dir_context {
1670 const filldir_t actor; 1670 filldir_t actor;
1671 loff_t pos; 1671 loff_t pos;
1672}; 1672};
1673 1673