diff options
author | Elena Reshetova <elena.reshetova@intel.com> | 2017-03-17 08:10:27 -0400 |
---|---|---|
committer | Ilya Dryomov <idryomov@gmail.com> | 2017-05-04 03:19:18 -0400 |
commit | 06dfa96399a9a3280dd81e47f8696aa89f1783e7 (patch) | |
tree | 1f5b529b617e1607087e096be6640b0208ec54aa /include/linux/ceph | |
parent | 805692d0e0f7dec42b5e05fb8b2a5c172f66a3c2 (diff) |
libceph: convert ceph_snap_context.nref from atomic_t to refcount_t
refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free
situations.
Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David Windsor <dwindsor@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Diffstat (limited to 'include/linux/ceph')
-rw-r--r-- | include/linux/ceph/libceph.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/linux/ceph/libceph.h b/include/linux/ceph/libceph.h index cecbf5a26e5a..3229ae6c7846 100644 --- a/include/linux/ceph/libceph.h +++ b/include/linux/ceph/libceph.h | |||
@@ -14,6 +14,7 @@ | |||
14 | #include <linux/wait.h> | 14 | #include <linux/wait.h> |
15 | #include <linux/writeback.h> | 15 | #include <linux/writeback.h> |
16 | #include <linux/slab.h> | 16 | #include <linux/slab.h> |
17 | #include <linux/refcount.h> | ||
17 | 18 | ||
18 | #include <linux/ceph/types.h> | 19 | #include <linux/ceph/types.h> |
19 | #include <linux/ceph/messenger.h> | 20 | #include <linux/ceph/messenger.h> |
@@ -161,7 +162,7 @@ struct ceph_client { | |||
161 | * dirtied. | 162 | * dirtied. |
162 | */ | 163 | */ |
163 | struct ceph_snap_context { | 164 | struct ceph_snap_context { |
164 | atomic_t nref; | 165 | refcount_t nref; |
165 | u64 seq; | 166 | u64 seq; |
166 | u32 num_snaps; | 167 | u32 num_snaps; |
167 | u64 snaps[]; | 168 | u64 snaps[]; |