diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2019-03-27 08:58:19 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2019-03-27 14:39:03 -0400 |
commit | ec8bf1942567bf0736314da9723e93bcc73c131f (patch) | |
tree | dde669c9599c4ff2aeacba7d780c7d757e6e744b /include/drm | |
parent | 9d5549d8a865793a1faf6ac9a48df08a3e850af6 (diff) |
drm/fb-helper: Fixup fill_info cleanup
I forgot the !CONFIG_FBDEV case. Also some kerneldoc needed more
adjusting.
Cc: Noralf Trønnes <noralf@tronnes.org>
Cc: Alex Deucher <alexander.deucher@amd.com>
Reported-by: kbuild test robot <lkp@intel.com>
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190327125819.16478-1-daniel.vetter@ffwll.ch
Diffstat (limited to 'include/drm')
-rw-r--r-- | include/drm/drm_fb_helper.h | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index f0732d27a341..81ae48a0df48 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h | |||
@@ -67,10 +67,8 @@ struct drm_fb_helper_crtc { | |||
67 | * according to the largest width/height (so it is large enough for all CRTCs | 67 | * according to the largest width/height (so it is large enough for all CRTCs |
68 | * to scanout). But the fbdev width/height is sized to the minimum width/ | 68 | * to scanout). But the fbdev width/height is sized to the minimum width/ |
69 | * height of all the displays. This ensures that fbcon fits on the smallest | 69 | * height of all the displays. This ensures that fbcon fits on the smallest |
70 | * of the attached displays. | 70 | * of the attached displays. fb_width/fb_height is used by |
71 | * | 71 | * drm_fb_helper_fill_info() to fill out the &fb_info.var structure. |
72 | * So what is passed to drm_fb_helper_fill_var() should be fb_width/fb_height, | ||
73 | * rather than the surface size. | ||
74 | */ | 72 | */ |
75 | struct drm_fb_helper_surface_size { | 73 | struct drm_fb_helper_surface_size { |
76 | u32 fb_width; | 74 | u32 fb_width; |
@@ -416,14 +414,10 @@ static inline void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper) | |||
416 | { | 414 | { |
417 | } | 415 | } |
418 | 416 | ||
419 | static inline void drm_fb_helper_fill_var(struct fb_info *info, | 417 | static inline void |
420 | struct drm_fb_helper *fb_helper, | 418 | drm_fb_helper_fill_info(struct fb_info *info, |
421 | uint32_t fb_width, uint32_t fb_height) | 419 | struct drm_fb_helper *fb_helper, |
422 | { | 420 | struct drm_fb_helper_surface_size *sizes) |
423 | } | ||
424 | |||
425 | static inline void drm_fb_helper_fill_fix(struct fb_info *info, uint32_t pitch, | ||
426 | uint32_t depth) | ||
427 | { | 421 | { |
428 | } | 422 | } |
429 | 423 | ||