summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorNikolay Borisov <nborisov@suse.com>2017-07-11 06:25:13 -0400
committerDavid Sterba <dsterba@suse.com>2017-08-16 10:12:01 -0400
commit7bdd6277e0dc2beb4f5db5ea4ff7670ecf0b5879 (patch)
tree7199cd78b2278196bc07ccf8689b44a2cc13098f /fs
parent6c6b5a39c4bf3dbd8cf629c9f5450e983c19dbb9 (diff)
btrfs: Remove redundant argument of flush_space
All callers of flush_space pass the same number for orig/num_bytes arguments. Let's remove one of the numbers and also modify the trace point to show only a single number - bytes requested. Seems that last point where the two parameters were treated differently is before the ticketed enospc rework. Signed-off-by: Nikolay Borisov <nborisov@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/btrfs/extent-tree.c16
1 files changed, 7 insertions, 9 deletions
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 6d04563585e6..288b38ae8791 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -4906,7 +4906,7 @@ struct reserve_ticket {
4906 4906
4907static int flush_space(struct btrfs_fs_info *fs_info, 4907static int flush_space(struct btrfs_fs_info *fs_info,
4908 struct btrfs_space_info *space_info, u64 num_bytes, 4908 struct btrfs_space_info *space_info, u64 num_bytes,
4909 u64 orig_bytes, int state) 4909 int state)
4910{ 4910{
4911 struct btrfs_root *root = fs_info->extent_root; 4911 struct btrfs_root *root = fs_info->extent_root;
4912 struct btrfs_trans_handle *trans; 4912 struct btrfs_trans_handle *trans;
@@ -4931,7 +4931,7 @@ static int flush_space(struct btrfs_fs_info *fs_info,
4931 break; 4931 break;
4932 case FLUSH_DELALLOC: 4932 case FLUSH_DELALLOC:
4933 case FLUSH_DELALLOC_WAIT: 4933 case FLUSH_DELALLOC_WAIT:
4934 shrink_delalloc(fs_info, num_bytes * 2, orig_bytes, 4934 shrink_delalloc(fs_info, num_bytes * 2, num_bytes,
4935 state == FLUSH_DELALLOC_WAIT); 4935 state == FLUSH_DELALLOC_WAIT);
4936 break; 4936 break;
4937 case ALLOC_CHUNK: 4937 case ALLOC_CHUNK:
@@ -4949,15 +4949,15 @@ static int flush_space(struct btrfs_fs_info *fs_info,
4949 break; 4949 break;
4950 case COMMIT_TRANS: 4950 case COMMIT_TRANS:
4951 ret = may_commit_transaction(fs_info, space_info, 4951 ret = may_commit_transaction(fs_info, space_info,
4952 orig_bytes, 0); 4952 num_bytes, 0);
4953 break; 4953 break;
4954 default: 4954 default:
4955 ret = -ENOSPC; 4955 ret = -ENOSPC;
4956 break; 4956 break;
4957 } 4957 }
4958 4958
4959 trace_btrfs_flush_space(fs_info, space_info->flags, num_bytes, 4959 trace_btrfs_flush_space(fs_info, space_info->flags, num_bytes, state,
4960 orig_bytes, state, ret); 4960 ret);
4961 return ret; 4961 return ret;
4962} 4962}
4963 4963
@@ -5063,8 +5063,7 @@ static void btrfs_async_reclaim_metadata_space(struct work_struct *work)
5063 struct reserve_ticket *ticket; 5063 struct reserve_ticket *ticket;
5064 int ret; 5064 int ret;
5065 5065
5066 ret = flush_space(fs_info, space_info, to_reclaim, to_reclaim, 5066 ret = flush_space(fs_info, space_info, to_reclaim, flush_state);
5067 flush_state);
5068 spin_lock(&space_info->lock); 5067 spin_lock(&space_info->lock);
5069 if (list_empty(&space_info->tickets)) { 5068 if (list_empty(&space_info->tickets)) {
5070 space_info->flush = 0; 5069 space_info->flush = 0;
@@ -5120,8 +5119,7 @@ static void priority_reclaim_metadata_space(struct btrfs_fs_info *fs_info,
5120 spin_unlock(&space_info->lock); 5119 spin_unlock(&space_info->lock);
5121 5120
5122 do { 5121 do {
5123 flush_space(fs_info, space_info, to_reclaim, to_reclaim, 5122 flush_space(fs_info, space_info, to_reclaim, flush_state);
5124 flush_state);
5125 flush_state++; 5123 flush_state++;
5126 spin_lock(&space_info->lock); 5124 spin_lock(&space_info->lock);
5127 if (ticket->bytes == 0) { 5125 if (ticket->bytes == 0) {