diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2017-04-28 13:13:17 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2017-04-28 13:13:17 -0400 |
commit | 28b2013587e535cef8bd8d8e0eae5ad40868369b (patch) | |
tree | 80b07dfce29e4e94e37660c47a621c368c05a6e8 /fs | |
parent | 8b5d11e4b095450e2f259d5f60ea18c13d2fe0a2 (diff) | |
parent | 338bd52f3c3a86a1feea8c9a121d1cee60d68d69 (diff) |
Merge branch 'for-linus-4.11' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs
Pull btrfs fix from Chris Mason:
"We have one more fix for btrfs.
This gets rid of a new WARN_ON from rc1 that ended up making more
noise than we really want. The larger fix for the underflow got
delayed a bit and it's better for now to put it under
CONFIG_BTRFS_DEBUG"
* 'for-linus-4.11' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs:
btrfs: qgroup: move noisy underflow warning to debugging build
Diffstat (limited to 'fs')
-rw-r--r-- | fs/btrfs/qgroup.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index a59801dc2a34..afbea61d957e 100644 --- a/fs/btrfs/qgroup.c +++ b/fs/btrfs/qgroup.c | |||
@@ -1042,9 +1042,12 @@ static void report_reserved_underflow(struct btrfs_fs_info *fs_info, | |||
1042 | struct btrfs_qgroup *qgroup, | 1042 | struct btrfs_qgroup *qgroup, |
1043 | u64 num_bytes) | 1043 | u64 num_bytes) |
1044 | { | 1044 | { |
1045 | btrfs_warn(fs_info, | 1045 | #ifdef CONFIG_BTRFS_DEBUG |
1046 | WARN_ON(qgroup->reserved < num_bytes); | ||
1047 | btrfs_debug(fs_info, | ||
1046 | "qgroup %llu reserved space underflow, have: %llu, to free: %llu", | 1048 | "qgroup %llu reserved space underflow, have: %llu, to free: %llu", |
1047 | qgroup->qgroupid, qgroup->reserved, num_bytes); | 1049 | qgroup->qgroupid, qgroup->reserved, num_bytes); |
1050 | #endif | ||
1048 | qgroup->reserved = 0; | 1051 | qgroup->reserved = 0; |
1049 | } | 1052 | } |
1050 | /* | 1053 | /* |
@@ -1075,7 +1078,7 @@ static int __qgroup_excl_accounting(struct btrfs_fs_info *fs_info, | |||
1075 | qgroup->excl += sign * num_bytes; | 1078 | qgroup->excl += sign * num_bytes; |
1076 | qgroup->excl_cmpr += sign * num_bytes; | 1079 | qgroup->excl_cmpr += sign * num_bytes; |
1077 | if (sign > 0) { | 1080 | if (sign > 0) { |
1078 | if (WARN_ON(qgroup->reserved < num_bytes)) | 1081 | if (qgroup->reserved < num_bytes) |
1079 | report_reserved_underflow(fs_info, qgroup, num_bytes); | 1082 | report_reserved_underflow(fs_info, qgroup, num_bytes); |
1080 | else | 1083 | else |
1081 | qgroup->reserved -= num_bytes; | 1084 | qgroup->reserved -= num_bytes; |
@@ -1100,7 +1103,7 @@ static int __qgroup_excl_accounting(struct btrfs_fs_info *fs_info, | |||
1100 | WARN_ON(sign < 0 && qgroup->excl < num_bytes); | 1103 | WARN_ON(sign < 0 && qgroup->excl < num_bytes); |
1101 | qgroup->excl += sign * num_bytes; | 1104 | qgroup->excl += sign * num_bytes; |
1102 | if (sign > 0) { | 1105 | if (sign > 0) { |
1103 | if (WARN_ON(qgroup->reserved < num_bytes)) | 1106 | if (qgroup->reserved < num_bytes) |
1104 | report_reserved_underflow(fs_info, qgroup, | 1107 | report_reserved_underflow(fs_info, qgroup, |
1105 | num_bytes); | 1108 | num_bytes); |
1106 | else | 1109 | else |
@@ -2469,7 +2472,7 @@ void btrfs_qgroup_free_refroot(struct btrfs_fs_info *fs_info, | |||
2469 | 2472 | ||
2470 | qg = unode_aux_to_qgroup(unode); | 2473 | qg = unode_aux_to_qgroup(unode); |
2471 | 2474 | ||
2472 | if (WARN_ON(qg->reserved < num_bytes)) | 2475 | if (qg->reserved < num_bytes) |
2473 | report_reserved_underflow(fs_info, qg, num_bytes); | 2476 | report_reserved_underflow(fs_info, qg, num_bytes); |
2474 | else | 2477 | else |
2475 | qg->reserved -= num_bytes; | 2478 | qg->reserved -= num_bytes; |