Merge tag 'for_v5.4-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs

Pull ext2, quota, udf fixes and cleanups from Jan Kara:

 - two small quota fixes (in grace time handling and possible missed
   accounting of preallocated blocks beyond EOF).

 - some ext2 cleanups

 - udf fixes for better compatibility with Windows 10 generated media
   (named streams, write-protection using domain-identifier, placement
   of volume recognition sequence)

 - some udf cleanups

* tag 'for_v5.4-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs:
  quota: fix wrong condition in is_quota_modification()
  fs-udf: Delete an unnecessary check before brelse()
  ext2: Delete an unnecessary check before brelse()
  udf: Drop forward function declarations
  udf: Verify domain identifier fields
  udf: augment UDF permissions on new inodes
  udf: Use dynamic debug infrastructure
  udf: reduce leakage of blocks related to named streams
  udf: prevent allocation beyond UDF partition
  quota: fix condition for resetting time limit in do_set_dqblk()
  ext2: code cleanup for ext2_free_blocks()
  ext2: fix block range in ext2_data_block_valid()
  udf: support 2048-byte spacing of VRS descriptors on 4K media
  udf: refactor VRS descriptor identification

1 files changed, 50 insertions, 5 deletions

diff --git a/fs/udf/inode.c b/fs/udf/inode.c
index 9bb18311a22f..ea80036d7897 100644
--- a/fs/udf/inode.c
+++ b/fs/udf/inode.c
@@ -45,6 +45,13 @@
 
 #define EXTENT_MERGE_SIZE 5
 
+#define FE_MAPPED_PERMS (FE_PERM_U_READ | FE_PERM_U_WRITE | FE_PERM_U_EXEC | \
+                         FE_PERM_G_READ | FE_PERM_G_WRITE | FE_PERM_G_EXEC | \
+                         FE_PERM_O_READ | FE_PERM_O_WRITE | FE_PERM_O_EXEC)
+
+#define FE_DELETE_PERMS (FE_PERM_U_DELETE | FE_PERM_G_DELETE | \
+                         FE_PERM_O_DELETE)
+
 static umode_t udf_convert_permissions(struct fileEntry *);
 static int udf_update_inode(struct inode *, int);
 static int udf_sync_inode(struct inode *inode);
@@ -1458,6 +1465,8 @@ reread:
         else
                 inode->i_mode = udf_convert_permissions(fe);
         inode->i_mode &= ~sbi->s_umask;
+        iinfo->i_extraPerms = le32_to_cpu(fe->permissions) & ~FE_MAPPED_PERMS;
+
         read_unlock(&sbi->s_cred_lock);
 
         link_count = le16_to_cpu(fe->fileLinkCount);
@@ -1485,6 +1494,8 @@ reread:
                 iinfo->i_lenEAttr = le32_to_cpu(fe->lengthExtendedAttr);
                 iinfo->i_lenAlloc = le32_to_cpu(fe->lengthAllocDescs);
                 iinfo->i_checkpoint = le32_to_cpu(fe->checkpoint);
+                iinfo->i_streamdir = 0;
+                iinfo->i_lenStreams = 0;
         } else {
                 inode->i_blocks = le64_to_cpu(efe->logicalBlocksRecorded) <<
                     (inode->i_sb->s_blocksize_bits - 9);
@@ -1498,6 +1509,16 @@ reread:
                 iinfo->i_lenEAttr = le32_to_cpu(efe->lengthExtendedAttr);
                 iinfo->i_lenAlloc = le32_to_cpu(efe->lengthAllocDescs);
                 iinfo->i_checkpoint = le32_to_cpu(efe->checkpoint);
+
+                /* Named streams */
+                iinfo->i_streamdir = (efe->streamDirectoryICB.extLength != 0);
+                iinfo->i_locStreamdir =
+                        lelb_to_cpu(efe->streamDirectoryICB.extLocation);
+                iinfo->i_lenStreams = le64_to_cpu(efe->objectSize);
+                if (iinfo->i_lenStreams >= inode->i_size)
+                        iinfo->i_lenStreams -= inode->i_size;
+                else
+                        iinfo->i_lenStreams = 0;
         }
         inode->i_generation = iinfo->i_unique;
 
@@ -1619,6 +1640,23 @@ static umode_t udf_convert_permissions(struct fileEntry *fe)
         return mode;
 }
 
+void udf_update_extra_perms(struct inode *inode, umode_t mode)
+{
+        struct udf_inode_info *iinfo = UDF_I(inode);
+
+        /*
+         * UDF 2.01 sec. 3.3.3.3 Note 2:
+         * In Unix, delete permission tracks write
+         */
+        iinfo->i_extraPerms &= ~FE_DELETE_PERMS;
+        if (mode & 0200)
+                iinfo->i_extraPerms |= FE_PERM_U_DELETE;
+        if (mode & 0020)
+                iinfo->i_extraPerms |= FE_PERM_G_DELETE;
+        if (mode & 0002)
+                iinfo->i_extraPerms |= FE_PERM_O_DELETE;
+}
+
 int udf_write_inode(struct inode *inode, struct writeback_control *wbc)
 {
         return udf_update_inode(inode, wbc->sync_mode == WB_SYNC_ALL);
@@ -1691,10 +1729,7 @@ static int udf_update_inode(struct inode *inode, int do_sync)
                    ((inode->i_mode & 0070) << 2) |
                    ((inode->i_mode & 0700) << 4);
 
-        udfperms |= (le32_to_cpu(fe->permissions) &
-                    (FE_PERM_O_DELETE | FE_PERM_O_CHATTR |
-                     FE_PERM_G_DELETE | FE_PERM_G_CHATTR |
-                     FE_PERM_U_DELETE | FE_PERM_U_CHATTR));
+        udfperms |= iinfo->i_extraPerms;
         fe->permissions = cpu_to_le32(udfperms);
 
         if (S_ISDIR(inode->i_mode) && inode->i_nlink > 0)
@@ -1760,9 +1795,19 @@ static int udf_update_inode(struct inode *inode, int do_sync)
                        iinfo->i_ext.i_data,
                        inode->i_sb->s_blocksize -
                                         sizeof(struct extendedFileEntry));
-                efe->objectSize = cpu_to_le64(inode->i_size);
+                efe->objectSize =
+                        cpu_to_le64(inode->i_size + iinfo->i_lenStreams);
                 efe->logicalBlocksRecorded = cpu_to_le64(lb_recorded);
 
+                if (iinfo->i_streamdir) {
+                        struct long_ad *icb_lad = &efe->streamDirectoryICB;
+
+                        icb_lad->extLocation =
+                                cpu_to_lelb(iinfo->i_locStreamdir);
+                        icb_lad->extLength =
+                                cpu_to_le32(inode->i_sb->s_blocksize);
+                }
+
                 udf_adjust_time(iinfo, inode->i_atime);
                 udf_adjust_time(iinfo, inode->i_mtime);
                 udf_adjust_time(iinfo, inode->i_ctime);