diff options
author | Joe Perches <joe@perches.com> | 2011-10-10 04:08:05 -0400 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2011-10-31 18:43:52 -0400 |
commit | 78ace70c4186c0d18314eb001637aa97d1585e65 (patch) | |
tree | 34227a6d50b93eb66df22ba130bea8ed932a5896 /fs/udf/inode.c | |
parent | a40ecd7b3ccf520ff02da93e8d1ba6cd55c2e359 (diff) |
udf: Convert printks to pr_<level>
Use the current logging styles.
Convert a few printks that should have been udf_warn and udf_err.
Coalesce formats. Add #define pr_fmt.
Move an #include "udfdecls.h" above other includes in udftime.c
so pr_fmt works correctly. Strip prefixes from conversions as appropriate.
Reorder logging definitions in udfdecl.h
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/udf/inode.c')
-rw-r--r-- | fs/udf/inode.c | 35 |
1 files changed, 15 insertions, 20 deletions
diff --git a/fs/udf/inode.c b/fs/udf/inode.c index f94d6f9febf5..f67e7e268c49 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c | |||
@@ -84,12 +84,10 @@ void udf_evict_inode(struct inode *inode) | |||
84 | end_writeback(inode); | 84 | end_writeback(inode); |
85 | if (iinfo->i_alloc_type != ICBTAG_FLAG_AD_IN_ICB && | 85 | if (iinfo->i_alloc_type != ICBTAG_FLAG_AD_IN_ICB && |
86 | inode->i_size != iinfo->i_lenExtents) { | 86 | inode->i_size != iinfo->i_lenExtents) { |
87 | printk(KERN_WARNING "UDF-fs (%s): Inode %lu (mode %o) has " | 87 | udf_warn(inode->i_sb, "Inode %lu (mode %o) has inode size %llu different from extent length %llu. Filesystem need not be standards compliant.\n", |
88 | "inode size %llu different from extent length %llu. " | 88 | inode->i_ino, inode->i_mode, |
89 | "Filesystem need not be standards compliant.\n", | 89 | (unsigned long long)inode->i_size, |
90 | inode->i_sb->s_id, inode->i_ino, inode->i_mode, | 90 | (unsigned long long)iinfo->i_lenExtents); |
91 | (unsigned long long)inode->i_size, | ||
92 | (unsigned long long)iinfo->i_lenExtents); | ||
93 | } | 91 | } |
94 | kfree(iinfo->i_ext.i_data); | 92 | kfree(iinfo->i_ext.i_data); |
95 | iinfo->i_ext.i_data = NULL; | 93 | iinfo->i_ext.i_data = NULL; |
@@ -1177,16 +1175,15 @@ static void __udf_read_inode(struct inode *inode) | |||
1177 | */ | 1175 | */ |
1178 | bh = udf_read_ptagged(inode->i_sb, &iinfo->i_location, 0, &ident); | 1176 | bh = udf_read_ptagged(inode->i_sb, &iinfo->i_location, 0, &ident); |
1179 | if (!bh) { | 1177 | if (!bh) { |
1180 | printk(KERN_ERR "udf: udf_read_inode(ino %ld) failed !bh\n", | 1178 | udf_err(inode->i_sb, "(ino %ld) failed !bh\n", inode->i_ino); |
1181 | inode->i_ino); | ||
1182 | make_bad_inode(inode); | 1179 | make_bad_inode(inode); |
1183 | return; | 1180 | return; |
1184 | } | 1181 | } |
1185 | 1182 | ||
1186 | if (ident != TAG_IDENT_FE && ident != TAG_IDENT_EFE && | 1183 | if (ident != TAG_IDENT_FE && ident != TAG_IDENT_EFE && |
1187 | ident != TAG_IDENT_USE) { | 1184 | ident != TAG_IDENT_USE) { |
1188 | printk(KERN_ERR "udf: udf_read_inode(ino %ld) " | 1185 | udf_err(inode->i_sb, "(ino %ld) failed ident=%d\n", |
1189 | "failed ident=%d\n", inode->i_ino, ident); | 1186 | inode->i_ino, ident); |
1190 | brelse(bh); | 1187 | brelse(bh); |
1191 | make_bad_inode(inode); | 1188 | make_bad_inode(inode); |
1192 | return; | 1189 | return; |
@@ -1226,8 +1223,8 @@ static void __udf_read_inode(struct inode *inode) | |||
1226 | } | 1223 | } |
1227 | brelse(ibh); | 1224 | brelse(ibh); |
1228 | } else if (fe->icbTag.strategyType != cpu_to_le16(4)) { | 1225 | } else if (fe->icbTag.strategyType != cpu_to_le16(4)) { |
1229 | printk(KERN_ERR "udf: unsupported strategy type: %d\n", | 1226 | udf_err(inode->i_sb, "unsupported strategy type: %d\n", |
1230 | le16_to_cpu(fe->icbTag.strategyType)); | 1227 | le16_to_cpu(fe->icbTag.strategyType)); |
1231 | brelse(bh); | 1228 | brelse(bh); |
1232 | make_bad_inode(inode); | 1229 | make_bad_inode(inode); |
1233 | return; | 1230 | return; |
@@ -1421,9 +1418,8 @@ static void udf_fill_inode(struct inode *inode, struct buffer_head *bh) | |||
1421 | udf_debug("METADATA BITMAP FILE-----\n"); | 1418 | udf_debug("METADATA BITMAP FILE-----\n"); |
1422 | break; | 1419 | break; |
1423 | default: | 1420 | default: |
1424 | printk(KERN_ERR "udf: udf_fill_inode(ino %ld) failed unknown " | 1421 | udf_err(inode->i_sb, "(ino %ld) failed unknown file type=%d\n", |
1425 | "file type=%d\n", inode->i_ino, | 1422 | inode->i_ino, fe->icbTag.fileType); |
1426 | fe->icbTag.fileType); | ||
1427 | make_bad_inode(inode); | 1423 | make_bad_inode(inode); |
1428 | return; | 1424 | return; |
1429 | } | 1425 | } |
@@ -1446,8 +1442,8 @@ static int udf_alloc_i_data(struct inode *inode, size_t size) | |||
1446 | iinfo->i_ext.i_data = kmalloc(size, GFP_KERNEL); | 1442 | iinfo->i_ext.i_data = kmalloc(size, GFP_KERNEL); |
1447 | 1443 | ||
1448 | if (!iinfo->i_ext.i_data) { | 1444 | if (!iinfo->i_ext.i_data) { |
1449 | printk(KERN_ERR "udf:udf_alloc_i_data (ino %ld) " | 1445 | udf_err(inode->i_sb, "(ino %ld) no free memory\n", |
1450 | "no free memory\n", inode->i_ino); | 1446 | inode->i_ino); |
1451 | return -ENOMEM; | 1447 | return -ENOMEM; |
1452 | } | 1448 | } |
1453 | 1449 | ||
@@ -1697,9 +1693,8 @@ out: | |||
1697 | if (do_sync) { | 1693 | if (do_sync) { |
1698 | sync_dirty_buffer(bh); | 1694 | sync_dirty_buffer(bh); |
1699 | if (buffer_write_io_error(bh)) { | 1695 | if (buffer_write_io_error(bh)) { |
1700 | printk(KERN_WARNING "IO error syncing udf inode " | 1696 | udf_warn(inode->i_sb, "IO error syncing udf inode [%08lx]\n", |
1701 | "[%s:%08lx]\n", inode->i_sb->s_id, | 1697 | inode->i_ino); |
1702 | inode->i_ino); | ||
1703 | err = -EIO; | 1698 | err = -EIO; |
1704 | } | 1699 | } |
1705 | } | 1700 | } |