diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2015-11-17 01:07:57 -0500 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2015-12-08 22:41:36 -0500 |
commit | 21fc61c73c3903c4c312d0802da01ec2b323d174 (patch) | |
tree | a26c29e3fbb766f00b023724e9e5b8b9bba9b879 /fs/squashfs | |
parent | aa80deab33a8fb180e718f5e45514db19aade165 (diff) |
don't put symlink bodies in pagecache into highmem
kmap() in page_follow_link_light() needed to go - allowing to hold
an arbitrary number of kmaps for long is a great way to deadlocking
the system.
new helper (inode_nohighmem(inode)) needs to be used for pagecache
symlinks inodes; done for all in-tree cases. page_follow_link_light()
instrumented to yell about anything missed.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/squashfs')
-rw-r--r-- | fs/squashfs/inode.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/squashfs/inode.c b/fs/squashfs/inode.c index a1ce5ce60632..0927b1e80ab6 100644 --- a/fs/squashfs/inode.c +++ b/fs/squashfs/inode.c | |||
@@ -41,6 +41,7 @@ | |||
41 | #include <linux/fs.h> | 41 | #include <linux/fs.h> |
42 | #include <linux/vfs.h> | 42 | #include <linux/vfs.h> |
43 | #include <linux/xattr.h> | 43 | #include <linux/xattr.h> |
44 | #include <linux/pagemap.h> | ||
44 | 45 | ||
45 | #include "squashfs_fs.h" | 46 | #include "squashfs_fs.h" |
46 | #include "squashfs_fs_sb.h" | 47 | #include "squashfs_fs_sb.h" |
@@ -291,6 +292,7 @@ int squashfs_read_inode(struct inode *inode, long long ino) | |||
291 | set_nlink(inode, le32_to_cpu(sqsh_ino->nlink)); | 292 | set_nlink(inode, le32_to_cpu(sqsh_ino->nlink)); |
292 | inode->i_size = le32_to_cpu(sqsh_ino->symlink_size); | 293 | inode->i_size = le32_to_cpu(sqsh_ino->symlink_size); |
293 | inode->i_op = &squashfs_symlink_inode_ops; | 294 | inode->i_op = &squashfs_symlink_inode_ops; |
295 | inode_nohighmem(inode); | ||
294 | inode->i_data.a_ops = &squashfs_symlink_aops; | 296 | inode->i_data.a_ops = &squashfs_symlink_aops; |
295 | inode->i_mode |= S_IFLNK; | 297 | inode->i_mode |= S_IFLNK; |
296 | squashfs_i(inode)->start = block; | 298 | squashfs_i(inode)->start = block; |