summaryrefslogtreecommitdiffstats
path: root/fs/quota
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2017-06-08 09:06:28 -0400
committerJan Kara <jack@suse.cz>2017-08-17 12:59:04 -0400
commitd6ab3661020cbf8a8909b49a8e1408d5ae434001 (patch)
tree5607206d8306bd409efa27212911b99fedeb188c /fs/quota
parent0cff9151d3fa27574c2201377a080e1b9b87b8ba (diff)
quota: Acquire dqio_sem for reading in vfs_load_quota_inode()
vfs_load_quota_inode() needs dqio_sem only for reading. In fact dqio_sem is not needed there at all since the function can be called only during quota on when quota file cannot be modified but let's leave the protection there since it is logical and the path is in no way performance critical. Reviewed-by: Andreas Dilger <adilger@dilger.ca> Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/quota')
-rw-r--r--fs/quota/dquot.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index 8d5ccad3bf3e..3852a3c79ac9 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -2331,15 +2331,15 @@ static int vfs_load_quota_inode(struct inode *inode, int type, int format_id,
2331 dqopt->info[type].dqi_format = fmt; 2331 dqopt->info[type].dqi_format = fmt;
2332 dqopt->info[type].dqi_fmt_id = format_id; 2332 dqopt->info[type].dqi_fmt_id = format_id;
2333 INIT_LIST_HEAD(&dqopt->info[type].dqi_dirty_list); 2333 INIT_LIST_HEAD(&dqopt->info[type].dqi_dirty_list);
2334 down_write(&dqopt->dqio_sem); 2334 down_read(&dqopt->dqio_sem);
2335 error = dqopt->ops[type]->read_file_info(sb, type); 2335 error = dqopt->ops[type]->read_file_info(sb, type);
2336 if (error < 0) { 2336 if (error < 0) {
2337 up_write(&dqopt->dqio_sem); 2337 up_read(&dqopt->dqio_sem);
2338 goto out_file_init; 2338 goto out_file_init;
2339 } 2339 }
2340 if (dqopt->flags & DQUOT_QUOTA_SYS_FILE) 2340 if (dqopt->flags & DQUOT_QUOTA_SYS_FILE)
2341 dqopt->info[type].dqi_flags |= DQF_SYS_FILE; 2341 dqopt->info[type].dqi_flags |= DQF_SYS_FILE;
2342 up_write(&dqopt->dqio_sem); 2342 up_read(&dqopt->dqio_sem);
2343 spin_lock(&dq_state_lock); 2343 spin_lock(&dq_state_lock);
2344 dqopt->flags |= dquot_state_flag(flags, type); 2344 dqopt->flags |= dquot_state_flag(flags, type);
2345 spin_unlock(&dq_state_lock); 2345 spin_unlock(&dq_state_lock);