diff options
author | Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> | 2016-05-23 19:23:17 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-05-23 20:04:14 -0400 |
commit | 24e20ead2fb2e1b67a76a04550d29c9027f707eb (patch) | |
tree | 9671eb107550a3bf8498040149600bea06bfc9bf /fs/nilfs2/ioctl.c | |
parent | 756cbdb353c597dd265f070527b5ee9901f35261 (diff) |
nilfs2: get rid of nilfs_mdt_mark_block_dirty()
nilfs_mdt_mark_block_dirty() can be replaced with primary functions
like nilfs_mdt_get_block() and mark_buffer_dirty(), and it's used only
by nilfs_ioctl_mark_blocks_dirty().
This gets rid of the function to simplify the interface of metadata
file.
Link: http://lkml.kernel.org/r/1461935747-10380-8-git-send-email-konishi.ryusuke@lab.ntt.co.jp
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/nilfs2/ioctl.c')
-rw-r--r-- | fs/nilfs2/ioctl.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c index e86599801d8b..358b57e2cdf9 100644 --- a/fs/nilfs2/ioctl.c +++ b/fs/nilfs2/ioctl.c | |||
@@ -779,6 +779,7 @@ static int nilfs_ioctl_mark_blocks_dirty(struct the_nilfs *nilfs, | |||
779 | size_t nmembs = argv->v_nmembs; | 779 | size_t nmembs = argv->v_nmembs; |
780 | struct nilfs_bmap *bmap = NILFS_I(nilfs->ns_dat)->i_bmap; | 780 | struct nilfs_bmap *bmap = NILFS_I(nilfs->ns_dat)->i_bmap; |
781 | struct nilfs_bdesc *bdescs = buf; | 781 | struct nilfs_bdesc *bdescs = buf; |
782 | struct buffer_head *bh; | ||
782 | int ret, i; | 783 | int ret, i; |
783 | 784 | ||
784 | for (i = 0; i < nmembs; i++) { | 785 | for (i = 0; i < nmembs; i++) { |
@@ -796,12 +797,16 @@ static int nilfs_ioctl_mark_blocks_dirty(struct the_nilfs *nilfs, | |||
796 | /* skip dead block */ | 797 | /* skip dead block */ |
797 | continue; | 798 | continue; |
798 | if (bdescs[i].bd_level == 0) { | 799 | if (bdescs[i].bd_level == 0) { |
799 | ret = nilfs_mdt_mark_block_dirty(nilfs->ns_dat, | 800 | ret = nilfs_mdt_get_block(nilfs->ns_dat, |
800 | bdescs[i].bd_offset); | 801 | bdescs[i].bd_offset, |
801 | if (ret < 0) { | 802 | false, NULL, &bh); |
803 | if (unlikely(ret)) { | ||
802 | WARN_ON(ret == -ENOENT); | 804 | WARN_ON(ret == -ENOENT); |
803 | return ret; | 805 | return ret; |
804 | } | 806 | } |
807 | mark_buffer_dirty(bh); | ||
808 | nilfs_mdt_mark_dirty(nilfs->ns_dat); | ||
809 | put_bh(bh); | ||
805 | } else { | 810 | } else { |
806 | ret = nilfs_bmap_mark(bmap, bdescs[i].bd_offset, | 811 | ret = nilfs_bmap_mark(bmap, bdescs[i].bd_offset, |
807 | bdescs[i].bd_level); | 812 | bdescs[i].bd_level); |