summaryrefslogtreecommitdiffstats
path: root/fs/nfsd/vfs.c
diff options
context:
space:
mode:
authorKinglong Mee <kinglongmee@gmail.com>2016-12-31 07:59:53 -0500
committerJ. Bruce Fields <bfields@redhat.com>2017-01-31 12:31:53 -0500
commit54bbb7d206db78a3dfd87bc8d9735cbe3ac3f938 (patch)
tree940db662527f1be3a5144f09094556cb614896c1 /fs/nfsd/vfs.c
parente35659f1b03c03946cae8abb6b0a9e170b574f1c (diff)
NFSD: pass an integer for stable type to nfsd_vfs_write
After fae5096ad217 "nfsd: assume writeable exportabled filesystems have f_sync" we no longer modify this argument. This is just cleanup, no change in functionality. Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/vfs.c')
-rw-r--r--fs/nfsd/vfs.c11
1 files changed, 5 insertions, 6 deletions
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index ca13236dbb1f..1bedb2bc907e 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -917,14 +917,13 @@ static int wait_for_concurrent_writes(struct file *file)
917__be32 917__be32
918nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file, 918nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
919 loff_t offset, struct kvec *vec, int vlen, 919 loff_t offset, struct kvec *vec, int vlen,
920 unsigned long *cnt, int *stablep) 920 unsigned long *cnt, int stable)
921{ 921{
922 struct svc_export *exp; 922 struct svc_export *exp;
923 struct inode *inode; 923 struct inode *inode;
924 mm_segment_t oldfs; 924 mm_segment_t oldfs;
925 __be32 err = 0; 925 __be32 err = 0;
926 int host_err; 926 int host_err;
927 int stable = *stablep;
928 int use_wgather; 927 int use_wgather;
929 loff_t pos = offset; 928 loff_t pos = offset;
930 unsigned int pflags = current->flags; 929 unsigned int pflags = current->flags;
@@ -945,7 +944,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
945 use_wgather = (rqstp->rq_vers == 2) && EX_WGATHER(exp); 944 use_wgather = (rqstp->rq_vers == 2) && EX_WGATHER(exp);
946 945
947 if (!EX_ISSYNC(exp)) 946 if (!EX_ISSYNC(exp))
948 stable = 0; 947 stable = NFS_UNSTABLE;
949 948
950 if (stable && !use_wgather) 949 if (stable && !use_wgather)
951 flags |= RWF_SYNC; 950 flags |= RWF_SYNC;
@@ -1014,7 +1013,7 @@ __be32 nfsd_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
1014__be32 1013__be32
1015nfsd_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file, 1014nfsd_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
1016 loff_t offset, struct kvec *vec, int vlen, unsigned long *cnt, 1015 loff_t offset, struct kvec *vec, int vlen, unsigned long *cnt,
1017 int *stablep) 1016 int stable)
1018{ 1017{
1019 __be32 err = 0; 1018 __be32 err = 0;
1020 1019
@@ -1027,7 +1026,7 @@ nfsd_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
1027 goto out; 1026 goto out;
1028 trace_write_opened(rqstp, fhp, offset, vlen); 1027 trace_write_opened(rqstp, fhp, offset, vlen);
1029 err = nfsd_vfs_write(rqstp, fhp, file, offset, vec, vlen, cnt, 1028 err = nfsd_vfs_write(rqstp, fhp, file, offset, vec, vlen, cnt,
1030 stablep); 1029 stable);
1031 trace_write_io_done(rqstp, fhp, offset, vlen); 1030 trace_write_io_done(rqstp, fhp, offset, vlen);
1032 } else { 1031 } else {
1033 err = nfsd_open(rqstp, fhp, S_IFREG, NFSD_MAY_WRITE, &file); 1032 err = nfsd_open(rqstp, fhp, S_IFREG, NFSD_MAY_WRITE, &file);
@@ -1037,7 +1036,7 @@ nfsd_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
1037 trace_write_opened(rqstp, fhp, offset, vlen); 1036 trace_write_opened(rqstp, fhp, offset, vlen);
1038 if (cnt) 1037 if (cnt)
1039 err = nfsd_vfs_write(rqstp, fhp, file, offset, vec, vlen, 1038 err = nfsd_vfs_write(rqstp, fhp, file, offset, vec, vlen,
1040 cnt, stablep); 1039 cnt, stable);
1041 trace_write_io_done(rqstp, fhp, offset, vlen); 1040 trace_write_io_done(rqstp, fhp, offset, vlen);
1042 fput(file); 1041 fput(file);
1043 } 1042 }