summaryrefslogtreecommitdiffstats
path: root/fs/nfs/write.c
diff options
context:
space:
mode:
authorNiels de Vos <ndevos@redhat.com>2013-12-17 12:20:16 -0500
committerTrond Myklebust <trond.myklebust@primarydata.com>2014-01-05 15:51:23 -0500
commit1e8968c5b0582392d5f132422f581e3ebc24e627 (patch)
tree1fbb842ca0b18d421f1e74b046324e38dbcb58c3 /fs/nfs/write.c
parenta8c2275493b866961f4429a741251c630c4fc6d7 (diff)
NFS: dprintk() should not print negative fileids and inode numbers
A fileid in NFS is a uint64. There are some occurrences where dprintk() outputs a signed fileid. This leads to confusion and more difficult to read debugging (negative fileids matching positive inode numbers). Signed-off-by: Niels de Vos <ndevos@redhat.com> CC: Santosh Pradhan <spradhan@redhat.com> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to 'fs/nfs/write.c')
-rw-r--r--fs/nfs/write.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index c1d548211c31..77a00c66c7d9 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -1013,10 +1013,10 @@ int nfs_initiate_write(struct rpc_clnt *clnt,
1013 NFS_PROTO(inode)->write_setup(data, &msg); 1013 NFS_PROTO(inode)->write_setup(data, &msg);
1014 1014
1015 dprintk("NFS: %5u initiated write call " 1015 dprintk("NFS: %5u initiated write call "
1016 "(req %s/%lld, %u bytes @ offset %llu)\n", 1016 "(req %s/%llu, %u bytes @ offset %llu)\n",
1017 data->task.tk_pid, 1017 data->task.tk_pid,
1018 inode->i_sb->s_id, 1018 inode->i_sb->s_id,
1019 (long long)NFS_FILEID(inode), 1019 (unsigned long long)NFS_FILEID(inode),
1020 data->args.count, 1020 data->args.count,
1021 (unsigned long long)data->args.offset); 1021 (unsigned long long)data->args.offset);
1022 1022
@@ -1606,9 +1606,9 @@ static void nfs_commit_release_pages(struct nfs_commit_data *data)
1606 nfs_list_remove_request(req); 1606 nfs_list_remove_request(req);
1607 nfs_clear_page_commit(req->wb_page); 1607 nfs_clear_page_commit(req->wb_page);
1608 1608
1609 dprintk("NFS: commit (%s/%lld %d@%lld)", 1609 dprintk("NFS: commit (%s/%llu %d@%lld)",
1610 req->wb_context->dentry->d_sb->s_id, 1610 req->wb_context->dentry->d_sb->s_id,
1611 (long long)NFS_FILEID(req->wb_context->dentry->d_inode), 1611 (unsigned long long)NFS_FILEID(req->wb_context->dentry->d_inode),
1612 req->wb_bytes, 1612 req->wb_bytes,
1613 (long long)req_offset(req)); 1613 (long long)req_offset(req));
1614 if (status < 0) { 1614 if (status < 0) {