diff options
author | Calum Mackay <calum.mackay@oracle.com> | 2018-07-05 12:08:08 -0400 |
---|---|---|
committer | Anna Schumaker <Anna.Schumaker@Netapp.com> | 2018-07-30 13:19:40 -0400 |
commit | 23a88ade7131aa259c532ab17685c76de562242b (patch) | |
tree | 42d0011a99e3d824d944d525bbcd4f632339142d /fs/nfs/nfs4client.c | |
parent | 8b199e58d49beaae33eaf11b68b7183eb28f1681 (diff) |
nfs: Referrals not inheriting proto setting from parent
Commit 530ea4219231 ("nfs: Referrals should use the same proto setting
as their parent") encloses the fix with #ifdef CONFIG_SUNRPC_XPRT_RDMA.
CONFIG_SUNRPC_XPRT_RDMA is a tristate option, so it should be tested
with #if IS_ENABLED().
Fixes: 530ea4219231 ("nfs: Referrals should use the same proto setting as their parent")
Reported-by: Helen Chao <helen.chao@oracle.com>
Tested-by: Helen Chao <helen.chao@oracle.com>
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Bill Baker <bill.baker@oracle.com>
Signed-off-by: Calum Mackay <calum.mackay@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'fs/nfs/nfs4client.c')
-rw-r--r-- | fs/nfs/nfs4client.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c index 979631411a0e..d7124fb12041 100644 --- a/fs/nfs/nfs4client.c +++ b/fs/nfs/nfs4client.c | |||
@@ -1127,7 +1127,7 @@ struct nfs_server *nfs4_create_referral_server(struct nfs_clone_mount *data, | |||
1127 | nfs_server_copy_userdata(server, parent_server); | 1127 | nfs_server_copy_userdata(server, parent_server); |
1128 | 1128 | ||
1129 | /* Get a client representation */ | 1129 | /* Get a client representation */ |
1130 | #ifdef CONFIG_SUNRPC_XPRT_RDMA | 1130 | #if IS_ENABLED(CONFIG_SUNRPC_XPRT_RDMA) |
1131 | rpc_set_port(data->addr, NFS_RDMA_PORT); | 1131 | rpc_set_port(data->addr, NFS_RDMA_PORT); |
1132 | error = nfs4_set_client(server, data->hostname, | 1132 | error = nfs4_set_client(server, data->hostname, |
1133 | data->addr, | 1133 | data->addr, |
@@ -1139,7 +1139,7 @@ struct nfs_server *nfs4_create_referral_server(struct nfs_clone_mount *data, | |||
1139 | parent_client->cl_net); | 1139 | parent_client->cl_net); |
1140 | if (!error) | 1140 | if (!error) |
1141 | goto init_server; | 1141 | goto init_server; |
1142 | #endif /* CONFIG_SUNRPC_XPRT_RDMA */ | 1142 | #endif /* IS_ENABLED(CONFIG_SUNRPC_XPRT_RDMA) */ |
1143 | 1143 | ||
1144 | rpc_set_port(data->addr, NFS_PORT); | 1144 | rpc_set_port(data->addr, NFS_PORT); |
1145 | error = nfs4_set_client(server, data->hostname, | 1145 | error = nfs4_set_client(server, data->hostname, |
@@ -1153,7 +1153,7 @@ struct nfs_server *nfs4_create_referral_server(struct nfs_clone_mount *data, | |||
1153 | if (error < 0) | 1153 | if (error < 0) |
1154 | goto error; | 1154 | goto error; |
1155 | 1155 | ||
1156 | #ifdef CONFIG_SUNRPC_XPRT_RDMA | 1156 | #if IS_ENABLED(CONFIG_SUNRPC_XPRT_RDMA) |
1157 | init_server: | 1157 | init_server: |
1158 | #endif | 1158 | #endif |
1159 | error = nfs_init_server_rpcclient(server, parent_server->client->cl_timeout, data->authflavor); | 1159 | error = nfs_init_server_rpcclient(server, parent_server->client->cl_timeout, data->authflavor); |