diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2017-09-14 21:54:01 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2017-09-14 21:54:01 -0400 |
commit | 0f0d12728e56c94d3289c6831243b6faeae8a19d (patch) | |
tree | bd52fd4ed6fba2a0d8bb95e7fc33f51ac299001d /fs/minix/inode.c | |
parent | 581bfce969cbfc7ce43ee92273be9cb7c3fdfa61 (diff) | |
parent | e462ec50cb5fad19f6003a3d8087f4a0945dd2b1 (diff) |
Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull mount flag updates from Al Viro:
"Another chunk of fmount preparations from dhowells; only trivial
conflicts for that part. It separates MS_... bits (very grotty
mount(2) ABI) from the struct super_block ->s_flags (kernel-internal,
only a small subset of MS_... stuff).
This does *not* convert the filesystems to new constants; only the
infrastructure is done here. The next step in that series is where the
conflicts would be; that's the conversion of filesystems. It's purely
mechanical and it's better done after the merge, so if you could run
something like
list=$(for i in MS_RDONLY MS_NOSUID MS_NODEV MS_NOEXEC MS_SYNCHRONOUS MS_MANDLOCK MS_DIRSYNC MS_NOATIME MS_NODIRATIME MS_SILENT MS_POSIXACL MS_KERNMOUNT MS_I_VERSION MS_LAZYTIME; do git grep -l $i fs drivers/staging/lustre drivers/mtd ipc mm include/linux; done|sort|uniq|grep -v '^fs/namespace.c$')
sed -i -e 's/\<MS_RDONLY\>/SB_RDONLY/g' \
-e 's/\<MS_NOSUID\>/SB_NOSUID/g' \
-e 's/\<MS_NODEV\>/SB_NODEV/g' \
-e 's/\<MS_NOEXEC\>/SB_NOEXEC/g' \
-e 's/\<MS_SYNCHRONOUS\>/SB_SYNCHRONOUS/g' \
-e 's/\<MS_MANDLOCK\>/SB_MANDLOCK/g' \
-e 's/\<MS_DIRSYNC\>/SB_DIRSYNC/g' \
-e 's/\<MS_NOATIME\>/SB_NOATIME/g' \
-e 's/\<MS_NODIRATIME\>/SB_NODIRATIME/g' \
-e 's/\<MS_SILENT\>/SB_SILENT/g' \
-e 's/\<MS_POSIXACL\>/SB_POSIXACL/g' \
-e 's/\<MS_KERNMOUNT\>/SB_KERNMOUNT/g' \
-e 's/\<MS_I_VERSION\>/SB_I_VERSION/g' \
-e 's/\<MS_LAZYTIME\>/SB_LAZYTIME/g' \
$list
and commit it with something along the lines of 'convert filesystems
away from use of MS_... constants' as commit message, it would save a
quite a bit of headache next cycle"
* 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
VFS: Differentiate mount flags (MS_*) from internal superblock flags
VFS: Convert sb->s_flags & MS_RDONLY to sb_rdonly(sb)
vfs: Add sb_rdonly(sb) to query the MS_RDONLY flag on s_flags
Diffstat (limited to 'fs/minix/inode.c')
-rw-r--r-- | fs/minix/inode.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/minix/inode.c b/fs/minix/inode.c index 6ac76b0434e9..b6829d679643 100644 --- a/fs/minix/inode.c +++ b/fs/minix/inode.c | |||
@@ -42,7 +42,7 @@ static void minix_put_super(struct super_block *sb) | |||
42 | int i; | 42 | int i; |
43 | struct minix_sb_info *sbi = minix_sb(sb); | 43 | struct minix_sb_info *sbi = minix_sb(sb); |
44 | 44 | ||
45 | if (!(sb->s_flags & MS_RDONLY)) { | 45 | if (!sb_rdonly(sb)) { |
46 | if (sbi->s_version != MINIX_V3) /* s_state is now out from V3 sb */ | 46 | if (sbi->s_version != MINIX_V3) /* s_state is now out from V3 sb */ |
47 | sbi->s_ms->s_state = sbi->s_mount_state; | 47 | sbi->s_ms->s_state = sbi->s_mount_state; |
48 | mark_buffer_dirty(sbi->s_sbh); | 48 | mark_buffer_dirty(sbi->s_sbh); |
@@ -125,7 +125,7 @@ static int minix_remount (struct super_block * sb, int * flags, char * data) | |||
125 | 125 | ||
126 | sync_filesystem(sb); | 126 | sync_filesystem(sb); |
127 | ms = sbi->s_ms; | 127 | ms = sbi->s_ms; |
128 | if ((*flags & MS_RDONLY) == (sb->s_flags & MS_RDONLY)) | 128 | if ((bool)(*flags & MS_RDONLY) == sb_rdonly(sb)) |
129 | return 0; | 129 | return 0; |
130 | if (*flags & MS_RDONLY) { | 130 | if (*flags & MS_RDONLY) { |
131 | if (ms->s_state & MINIX_VALID_FS || | 131 | if (ms->s_state & MINIX_VALID_FS || |
@@ -293,7 +293,7 @@ static int minix_fill_super(struct super_block *s, void *data, int silent) | |||
293 | if (!s->s_root) | 293 | if (!s->s_root) |
294 | goto out_no_root; | 294 | goto out_no_root; |
295 | 295 | ||
296 | if (!(s->s_flags & MS_RDONLY)) { | 296 | if (!sb_rdonly(s)) { |
297 | if (sbi->s_version != MINIX_V3) /* s_state is now out from V3 sb */ | 297 | if (sbi->s_version != MINIX_V3) /* s_state is now out from V3 sb */ |
298 | ms->s_state &= ~MINIX_VALID_FS; | 298 | ms->s_state &= ~MINIX_VALID_FS; |
299 | mark_buffer_dirty(bh); | 299 | mark_buffer_dirty(bh); |