summaryrefslogtreecommitdiffstats
path: root/fs/fuse/inode.c
diff options
context:
space:
mode:
authorKirill A. Shutemov <kirill.shutemov@linux.intel.com>2016-04-01 08:29:47 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2016-04-04 13:41:08 -0400
commit09cbfeaf1a5a67bfb3201e0c83c810cecb2efa5a (patch)
tree6cdf210c9c0f981cd22544feeba701892ec19464 /fs/fuse/inode.c
parentc05c2ec96bb8b7310da1055c7b9d786a3ec6dc0c (diff)
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time ago with promise that one day it will be possible to implement page cache with bigger chunks than PAGE_SIZE. This promise never materialized. And unlikely will. We have many places where PAGE_CACHE_SIZE assumed to be equal to PAGE_SIZE. And it's constant source of confusion on whether PAGE_CACHE_* or PAGE_* constant should be used in a particular case, especially on the border between fs and mm. Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much breakage to be doable. Let's stop pretending that pages in page cache are special. They are not. The changes are pretty straight-forward: - <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>; - <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>; - PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN}; - page_cache_get() -> get_page(); - page_cache_release() -> put_page(); This patch contains automated changes generated with coccinelle using script below. For some reason, coccinelle doesn't patch header files. I've called spatch for them manually. The only adjustment after coccinelle is revert of changes to PAGE_CAHCE_ALIGN definition: we are going to drop it later. There are few places in the code where coccinelle didn't reach. I'll fix them manually in a separate patch. Comments and documentation also will be addressed with the separate patch. virtual patch @@ expression E; @@ - E << (PAGE_CACHE_SHIFT - PAGE_SHIFT) + E @@ expression E; @@ - E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) + E @@ @@ - PAGE_CACHE_SHIFT + PAGE_SHIFT @@ @@ - PAGE_CACHE_SIZE + PAGE_SIZE @@ @@ - PAGE_CACHE_MASK + PAGE_MASK @@ expression E; @@ - PAGE_CACHE_ALIGN(E) + PAGE_ALIGN(E) @@ expression E; @@ - page_cache_get(E) + get_page(E) @@ expression E; @@ - page_cache_release(E) + put_page(E) Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Acked-by: Michal Hocko <mhocko@suse.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/fuse/inode.c')
-rw-r--r--fs/fuse/inode.c16
1 files changed, 8 insertions, 8 deletions
diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index 4d69d5c0bedc..1ce67668a8e1 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -339,11 +339,11 @@ int fuse_reverse_inval_inode(struct super_block *sb, u64 nodeid,
339 339
340 fuse_invalidate_attr(inode); 340 fuse_invalidate_attr(inode);
341 if (offset >= 0) { 341 if (offset >= 0) {
342 pg_start = offset >> PAGE_CACHE_SHIFT; 342 pg_start = offset >> PAGE_SHIFT;
343 if (len <= 0) 343 if (len <= 0)
344 pg_end = -1; 344 pg_end = -1;
345 else 345 else
346 pg_end = (offset + len - 1) >> PAGE_CACHE_SHIFT; 346 pg_end = (offset + len - 1) >> PAGE_SHIFT;
347 invalidate_inode_pages2_range(inode->i_mapping, 347 invalidate_inode_pages2_range(inode->i_mapping,
348 pg_start, pg_end); 348 pg_start, pg_end);
349 } 349 }
@@ -864,7 +864,7 @@ static void process_init_reply(struct fuse_conn *fc, struct fuse_req *req)
864 process_init_limits(fc, arg); 864 process_init_limits(fc, arg);
865 865
866 if (arg->minor >= 6) { 866 if (arg->minor >= 6) {
867 ra_pages = arg->max_readahead / PAGE_CACHE_SIZE; 867 ra_pages = arg->max_readahead / PAGE_SIZE;
868 if (arg->flags & FUSE_ASYNC_READ) 868 if (arg->flags & FUSE_ASYNC_READ)
869 fc->async_read = 1; 869 fc->async_read = 1;
870 if (!(arg->flags & FUSE_POSIX_LOCKS)) 870 if (!(arg->flags & FUSE_POSIX_LOCKS))
@@ -901,7 +901,7 @@ static void process_init_reply(struct fuse_conn *fc, struct fuse_req *req)
901 if (arg->time_gran && arg->time_gran <= 1000000000) 901 if (arg->time_gran && arg->time_gran <= 1000000000)
902 fc->sb->s_time_gran = arg->time_gran; 902 fc->sb->s_time_gran = arg->time_gran;
903 } else { 903 } else {
904 ra_pages = fc->max_read / PAGE_CACHE_SIZE; 904 ra_pages = fc->max_read / PAGE_SIZE;
905 fc->no_lock = 1; 905 fc->no_lock = 1;
906 fc->no_flock = 1; 906 fc->no_flock = 1;
907 } 907 }
@@ -922,7 +922,7 @@ static void fuse_send_init(struct fuse_conn *fc, struct fuse_req *req)
922 922
923 arg->major = FUSE_KERNEL_VERSION; 923 arg->major = FUSE_KERNEL_VERSION;
924 arg->minor = FUSE_KERNEL_MINOR_VERSION; 924 arg->minor = FUSE_KERNEL_MINOR_VERSION;
925 arg->max_readahead = fc->bdi.ra_pages * PAGE_CACHE_SIZE; 925 arg->max_readahead = fc->bdi.ra_pages * PAGE_SIZE;
926 arg->flags |= FUSE_ASYNC_READ | FUSE_POSIX_LOCKS | FUSE_ATOMIC_O_TRUNC | 926 arg->flags |= FUSE_ASYNC_READ | FUSE_POSIX_LOCKS | FUSE_ATOMIC_O_TRUNC |
927 FUSE_EXPORT_SUPPORT | FUSE_BIG_WRITES | FUSE_DONT_MASK | 927 FUSE_EXPORT_SUPPORT | FUSE_BIG_WRITES | FUSE_DONT_MASK |
928 FUSE_SPLICE_WRITE | FUSE_SPLICE_MOVE | FUSE_SPLICE_READ | 928 FUSE_SPLICE_WRITE | FUSE_SPLICE_MOVE | FUSE_SPLICE_READ |
@@ -955,7 +955,7 @@ static int fuse_bdi_init(struct fuse_conn *fc, struct super_block *sb)
955 int err; 955 int err;
956 956
957 fc->bdi.name = "fuse"; 957 fc->bdi.name = "fuse";
958 fc->bdi.ra_pages = (VM_MAX_READAHEAD * 1024) / PAGE_CACHE_SIZE; 958 fc->bdi.ra_pages = (VM_MAX_READAHEAD * 1024) / PAGE_SIZE;
959 /* fuse does it's own writeback accounting */ 959 /* fuse does it's own writeback accounting */
960 fc->bdi.capabilities = BDI_CAP_NO_ACCT_WB | BDI_CAP_STRICTLIMIT; 960 fc->bdi.capabilities = BDI_CAP_NO_ACCT_WB | BDI_CAP_STRICTLIMIT;
961 961
@@ -1053,8 +1053,8 @@ static int fuse_fill_super(struct super_block *sb, void *data, int silent)
1053 goto err; 1053 goto err;
1054#endif 1054#endif
1055 } else { 1055 } else {
1056 sb->s_blocksize = PAGE_CACHE_SIZE; 1056 sb->s_blocksize = PAGE_SIZE;
1057 sb->s_blocksize_bits = PAGE_CACHE_SHIFT; 1057 sb->s_blocksize_bits = PAGE_SHIFT;
1058 } 1058 }
1059 sb->s_magic = FUSE_SUPER_MAGIC; 1059 sb->s_magic = FUSE_SUPER_MAGIC;
1060 sb->s_op = &fuse_super_operations; 1060 sb->s_op = &fuse_super_operations;