diff options
author | Maxim Patlasov <mpatlasov@parallels.com> | 2012-10-26 11:49:00 -0400 |
---|---|---|
committer | Miklos Szeredi <mszeredi@suse.cz> | 2013-01-24 10:21:26 -0500 |
commit | d07f09f509fb21482096e1975f160b694c0edf84 (patch) | |
tree | 657076e651b8dee622581b754f9e752461bad98d /fs/fuse/file.c | |
parent | f8dbdf81821b5ab4c5e86e7b2bd7edb892c159c2 (diff) |
fuse: rework fuse_perform_write()
The patch allocates as many page pointers in fuse_req as needed to cover
interval [pos .. pos+len-1]. Inline helper fuse_wr_pages() is introduced
to hide this cumbersome arithmetic.
Signed-off-by: Maxim Patlasov <mpatlasov@parallels.com>
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Diffstat (limited to 'fs/fuse/file.c')
-rw-r--r-- | fs/fuse/file.c | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 5fd06bae1790..b9972502f43a 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c | |||
@@ -881,11 +881,19 @@ static ssize_t fuse_fill_write_pages(struct fuse_req *req, | |||
881 | if (!fc->big_writes) | 881 | if (!fc->big_writes) |
882 | break; | 882 | break; |
883 | } while (iov_iter_count(ii) && count < fc->max_write && | 883 | } while (iov_iter_count(ii) && count < fc->max_write && |
884 | req->num_pages < FUSE_MAX_PAGES_PER_REQ && offset == 0); | 884 | req->num_pages < req->max_pages && offset == 0); |
885 | 885 | ||
886 | return count > 0 ? count : err; | 886 | return count > 0 ? count : err; |
887 | } | 887 | } |
888 | 888 | ||
889 | static inline unsigned fuse_wr_pages(loff_t pos, size_t len) | ||
890 | { | ||
891 | return min_t(unsigned, | ||
892 | ((pos + len - 1) >> PAGE_CACHE_SHIFT) - | ||
893 | (pos >> PAGE_CACHE_SHIFT) + 1, | ||
894 | FUSE_MAX_PAGES_PER_REQ); | ||
895 | } | ||
896 | |||
889 | static ssize_t fuse_perform_write(struct file *file, | 897 | static ssize_t fuse_perform_write(struct file *file, |
890 | struct address_space *mapping, | 898 | struct address_space *mapping, |
891 | struct iov_iter *ii, loff_t pos) | 899 | struct iov_iter *ii, loff_t pos) |
@@ -901,8 +909,9 @@ static ssize_t fuse_perform_write(struct file *file, | |||
901 | do { | 909 | do { |
902 | struct fuse_req *req; | 910 | struct fuse_req *req; |
903 | ssize_t count; | 911 | ssize_t count; |
912 | unsigned nr_pages = fuse_wr_pages(pos, iov_iter_count(ii)); | ||
904 | 913 | ||
905 | req = fuse_get_req(fc, FUSE_MAX_PAGES_PER_REQ); | 914 | req = fuse_get_req(fc, nr_pages); |
906 | if (IS_ERR(req)) { | 915 | if (IS_ERR(req)) { |
907 | err = PTR_ERR(req); | 916 | err = PTR_ERR(req); |
908 | break; | 917 | break; |