fs: add a VALID_OPEN_FLAGS

Add a central define for all valid open flags, and use it in the uniqueness
check.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

1 files changed, 4 insertions, 10 deletions

diff --git a/fs/fcntl.c b/fs/fcntl.c
index be8fbe289087..de1b16bb6a29 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -742,16 +742,10 @@ static int __init fcntl_init(void)
          * Exceptions: O_NONBLOCK is a two bit define on parisc; O_NDELAY
          * is defined as O_NONBLOCK on some platforms and not on others.
          */
-        BUILD_BUG_ON(21 - 1 /* for O_RDONLY being 0 */ != HWEIGHT32(
-                O_RDONLY        | O_WRONLY      | O_RDWR        |
-                O_CREAT         | O_EXCL        | O_NOCTTY      |
-                O_TRUNC         | O_APPEND      | /* O_NONBLOCK | */
-                __O_SYNC        | O_DSYNC       | FASYNC        |
-                O_DIRECT        | O_LARGEFILE   | O_DIRECTORY   |
-                O_NOFOLLOW      | O_NOATIME     | O_CLOEXEC     |
-                __FMODE_EXEC    | O_PATH        | __O_TMPFILE   |
-                __FMODE_NONOTIFY
-                ));
+        BUILD_BUG_ON(21 - 1 /* for O_RDONLY being 0 */ !=
+                HWEIGHT32(
+                        (VALID_OPEN_FLAGS & ~(O_NONBLOCK | O_NDELAY)) |
+                        __FMODE_EXEC | __FMODE_NONOTIFY));
 
         fasync_cache = kmem_cache_create("fasync_cache",
                 sizeof(struct fasync_struct), 0, SLAB_PANIC, NULL);