diff options
author | Tao Ma <boyu.mt@taobao.com> | 2012-10-22 00:34:32 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2012-10-22 00:34:32 -0400 |
commit | 79f1ba49569e5aec919b653c55b03274c2331701 (patch) | |
tree | 612d4200d13a10d5df0cb6508cc5b1e7fd10fd45 /fs/ext4/ialloc.c | |
parent | 76495ec1d47e1c0fe0673faf9179bda6bc8ab5c2 (diff) |
ext4: Checksum the block bitmap properly with bigalloc enabled
In mke2fs, we only checksum the whole bitmap block and it is right.
While in the kernel, we use EXT4_BLOCKS_PER_GROUP to indicate the
size of the checksumed bitmap which is wrong when we enable bigalloc.
The right size should be EXT4_CLUSTERS_PER_GROUP and this patch fixes
it.
Also as every caller of ext4_block_bitmap_csum_set and
ext4_block_bitmap_csum_verify pass in EXT4_BLOCKS_PER_GROUP(sb)/8,
we'd better removes this parameter and sets it in the function itself.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Cc: stable@vger.kernel.org
Diffstat (limited to 'fs/ext4/ialloc.c')
-rw-r--r-- | fs/ext4/ialloc.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index fa36372f3fdf..4facdd29a350 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c | |||
@@ -762,9 +762,7 @@ got: | |||
762 | ext4_free_group_clusters_set(sb, gdp, | 762 | ext4_free_group_clusters_set(sb, gdp, |
763 | ext4_free_clusters_after_init(sb, group, gdp)); | 763 | ext4_free_clusters_after_init(sb, group, gdp)); |
764 | ext4_block_bitmap_csum_set(sb, group, gdp, | 764 | ext4_block_bitmap_csum_set(sb, group, gdp, |
765 | block_bitmap_bh, | 765 | block_bitmap_bh); |
766 | EXT4_BLOCKS_PER_GROUP(sb) / | ||
767 | 8); | ||
768 | ext4_group_desc_csum_set(sb, group, gdp); | 766 | ext4_group_desc_csum_set(sb, group, gdp); |
769 | } | 767 | } |
770 | ext4_unlock_group(sb, group); | 768 | ext4_unlock_group(sb, group); |