diff options
author | Pankaj Gupta <pagupta@redhat.com> | 2019-07-05 10:03:27 -0400 |
---|---|---|
committer | Dan Williams <dan.j.williams@intel.com> | 2019-07-05 18:19:10 -0400 |
commit | e46bfc3f03d7894c0eb47c7d754c38bafe39e197 (patch) | |
tree | 5a90c4400c9c87a22f25189160ef503e5c5d609d /fs/ext4/file.c | |
parent | 32de1484648a837db5dea0a7007fe7136804e392 (diff) |
ext4: disable map_sync for async flush
Dont support 'MAP_SYNC' with non-DAX files and DAX files
with asynchronous dax_device. Virtio pmem provides
asynchronous host page cache flush mechanism. We don't
support 'MAP_SYNC' with virtio pmem and ext4.
Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'fs/ext4/file.c')
-rw-r--r-- | fs/ext4/file.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 2c5baa5e8291..4feeecae8db6 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c | |||
@@ -367,15 +367,17 @@ static const struct vm_operations_struct ext4_file_vm_ops = { | |||
367 | static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma) | 367 | static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma) |
368 | { | 368 | { |
369 | struct inode *inode = file->f_mapping->host; | 369 | struct inode *inode = file->f_mapping->host; |
370 | struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); | ||
371 | struct dax_device *dax_dev = sbi->s_daxdev; | ||
370 | 372 | ||
371 | if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) | 373 | if (unlikely(ext4_forced_shutdown(sbi))) |
372 | return -EIO; | 374 | return -EIO; |
373 | 375 | ||
374 | /* | 376 | /* |
375 | * We don't support synchronous mappings for non-DAX files. At least | 377 | * We don't support synchronous mappings for non-DAX files and |
376 | * until someone comes with a sensible use case. | 378 | * for DAX files if underneath dax_device is not synchronous. |
377 | */ | 379 | */ |
378 | if (!IS_DAX(file_inode(file)) && (vma->vm_flags & VM_SYNC)) | 380 | if (!daxdev_mapping_supported(vma, dax_dev)) |
379 | return -EOPNOTSUPP; | 381 | return -EOPNOTSUPP; |
380 | 382 | ||
381 | file_accessed(file); | 383 | file_accessed(file); |