diff options
author | Deepa Dinamani <deepa.kernel@gmail.com> | 2018-01-21 21:04:24 -0500 |
---|---|---|
committer | Deepa Dinamani <deepa.kernel@gmail.com> | 2019-08-30 10:27:18 -0400 |
commit | 4881c4971df04107b37c29bb6c719ec29ceb6571 (patch) | |
tree | 3704bb4fff9c349f6e395dac4cad4d370179f935 /fs/ext4/ext4.h | |
parent | d5c6e2d5188d9677462f3827034d060372a13b6e (diff) |
ext4: Initialize timestamps limits
ext4 has different overflow limits for max filesystem
timestamps based on the extra bytes available.
The timestamp limits are calculated according to the
encoding table in
a4dad1ae24f85i(ext4: Fix handling of extended tv_sec):
* extra msb of adjust for signed
* epoch 32-bit 32-bit tv_sec to
* bits time decoded 64-bit tv_sec 64-bit tv_sec valid time range
* 0 0 1 -0x80000000..-0x00000001 0x000000000 1901-12-13..1969-12-31
* 0 0 0 0x000000000..0x07fffffff 0x000000000 1970-01-01..2038-01-19
* 0 1 1 0x080000000..0x0ffffffff 0x100000000 2038-01-19..2106-02-07
* 0 1 0 0x100000000..0x17fffffff 0x100000000 2106-02-07..2174-02-25
* 1 0 1 0x180000000..0x1ffffffff 0x200000000 2174-02-25..2242-03-16
* 1 0 0 0x200000000..0x27fffffff 0x200000000 2242-03-16..2310-04-04
* 1 1 1 0x280000000..0x2ffffffff 0x300000000 2310-04-04..2378-04-22
* 1 1 0 0x300000000..0x37fffffff 0x300000000 2378-04-22..2446-05-10
Note that the time limits are not correct for deletion times.
Added a warn when an inode cannot be extended to incorporate an
extended timestamp.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Acked-by: Jeff Layton <jlayton@kernel.org>
Cc: tytso@mit.edu
Cc: adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org
Diffstat (limited to 'fs/ext4/ext4.h')
-rw-r--r-- | fs/ext4/ext4.h | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index bf660aa7a9e0..9e3ae3be3de9 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h | |||
@@ -828,11 +828,15 @@ static inline void ext4_decode_extra_time(struct timespec64 *time, | |||
828 | 828 | ||
829 | #define EXT4_INODE_SET_XTIME(xtime, inode, raw_inode) \ | 829 | #define EXT4_INODE_SET_XTIME(xtime, inode, raw_inode) \ |
830 | do { \ | 830 | do { \ |
831 | (raw_inode)->xtime = cpu_to_le32((inode)->xtime.tv_sec); \ | ||
832 | if (EXT4_FITS_IN_INODE(raw_inode, EXT4_I(inode), xtime ## _extra)) {\ | 831 | if (EXT4_FITS_IN_INODE(raw_inode, EXT4_I(inode), xtime ## _extra)) {\ |
832 | (raw_inode)->xtime = cpu_to_le32((inode)->xtime.tv_sec); \ | ||
833 | (raw_inode)->xtime ## _extra = \ | 833 | (raw_inode)->xtime ## _extra = \ |
834 | ext4_encode_extra_time(&(inode)->xtime); \ | 834 | ext4_encode_extra_time(&(inode)->xtime); \ |
835 | } \ | 835 | } \ |
836 | else {\ | ||
837 | (raw_inode)->xtime = cpu_to_le32(clamp_t(int32_t, (inode)->xtime.tv_sec, S32_MIN, S32_MAX)); \ | ||
838 | ext4_warning_inode(inode, "inode does not support timestamps beyond 2038"); \ | ||
839 | } \ | ||
836 | } while (0) | 840 | } while (0) |
837 | 841 | ||
838 | #define EXT4_EINODE_SET_XTIME(xtime, einode, raw_inode) \ | 842 | #define EXT4_EINODE_SET_XTIME(xtime, einode, raw_inode) \ |
@@ -1632,6 +1636,10 @@ static inline void ext4_clear_state_flags(struct ext4_inode_info *ei) | |||
1632 | 1636 | ||
1633 | #define EXT4_GOOD_OLD_INODE_SIZE 128 | 1637 | #define EXT4_GOOD_OLD_INODE_SIZE 128 |
1634 | 1638 | ||
1639 | #define EXT4_EXTRA_TIMESTAMP_MAX (((s64)1 << 34) - 1 + S32_MIN) | ||
1640 | #define EXT4_NON_EXTRA_TIMESTAMP_MAX S32_MAX | ||
1641 | #define EXT4_TIMESTAMP_MIN S32_MIN | ||
1642 | |||
1635 | /* | 1643 | /* |
1636 | * Feature set definitions | 1644 | * Feature set definitions |
1637 | */ | 1645 | */ |