diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-12-11 17:08:47 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-12-11 17:08:47 -0500 |
commit | c6bd5bcc4983f1a2d2f87a3769bf309482ee8c04 (patch) | |
tree | 2ff9c4496dc2258d601a1bcd82040470704dae3b /fs/devpts/inode.c | |
parent | 8966961b31c251b854169e9886394c2a20f2cea7 (diff) | |
parent | b0ab02361167faa82198b783a8d555eb6f58901c (diff) |
Merge tag 'tty-3.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
Pull TTY/Serial merge from Greg Kroah-Hartman:
"Here's the big tty/serial tree set of changes for 3.8-rc1.
Contained in here is a bunch more reworks of the tty port layer from
Jiri and bugfixes from Alan, along with a number of other tty and
serial driver updates by the various driver authors.
Also, Jiri has been coerced^Wconvinced to be the co-maintainer of the
TTY layer, which is much appreciated by me.
All of these have been in the linux-next tree for a while.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>"
Fixed up some trivial conflicts in the staging tree, due to the fwserial
driver having come in both ways (but fixed up a bit in the serial tree),
and the ioctl handling in the dgrp driver having been done slightly
differently (staging tree got that one right, and removed both
TIOCGSOFTCAR and TIOCSSOFTCAR).
* tag 'tty-3.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty: (146 commits)
staging: sb105x: fix potential NULL pointer dereference in mp_chars_in_buffer()
staging/fwserial: Remove superfluous free
staging/fwserial: Use WARN_ONCE when port table is corrupted
staging/fwserial: Destruct embedded tty_port on teardown
staging/fwserial: Fix build breakage when !CONFIG_BUG
staging: fwserial: Add TTY-over-Firewire serial driver
drivers/tty/serial/serial_core.c: clean up HIGH_BITS_OFFSET usage
staging: dgrp: dgrp_tty.c: Audit the return values of get/put_user()
staging: dgrp: dgrp_tty.c: Remove the TIOCSSOFTCAR ioctl handler from dgrp driver
serial: ifx6x60: Add modem power off function in the platform reboot process
serial: mxs-auart: unmap the scatter list before we copy the data
serial: mxs-auart: disable the Receive Timeout Interrupt when DMA is enabled
serial: max310x: Setup missing "can_sleep" field for GPIO
tty/serial: fix ifx6x60.c declaration warning
serial: samsung: add devicetree properties for non-Exynos SoCs
serial: samsung: fix potential soft lockup during uart write
tty: vt: Remove redundant null check before kfree.
tty/8250 Add check for pci_ioremap_bar failure
tty/8250 Add support for Commtech's Fastcom Async-335 and Fastcom Async-PCIe cards
tty/8250 Add XR17D15x devices to the exar_handle_irq override
...
Diffstat (limited to 'fs/devpts/inode.c')
-rw-r--r-- | fs/devpts/inode.c | 61 |
1 files changed, 36 insertions, 25 deletions
diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c index 14afbabe6546..472e6befc54d 100644 --- a/fs/devpts/inode.c +++ b/fs/devpts/inode.c | |||
@@ -545,37 +545,38 @@ void devpts_kill_index(struct inode *ptmx_inode, int idx) | |||
545 | mutex_unlock(&allocated_ptys_lock); | 545 | mutex_unlock(&allocated_ptys_lock); |
546 | } | 546 | } |
547 | 547 | ||
548 | int devpts_pty_new(struct inode *ptmx_inode, struct tty_struct *tty) | 548 | /** |
549 | * devpts_pty_new -- create a new inode in /dev/pts/ | ||
550 | * @ptmx_inode: inode of the master | ||
551 | * @device: major+minor of the node to be created | ||
552 | * @index: used as a name of the node | ||
553 | * @priv: what's given back by devpts_get_priv | ||
554 | * | ||
555 | * The created inode is returned. Remove it from /dev/pts/ by devpts_pty_kill. | ||
556 | */ | ||
557 | struct inode *devpts_pty_new(struct inode *ptmx_inode, dev_t device, int index, | ||
558 | void *priv) | ||
549 | { | 559 | { |
550 | /* tty layer puts index from devpts_new_index() in here */ | ||
551 | int number = tty->index; | ||
552 | struct tty_driver *driver = tty->driver; | ||
553 | dev_t device = MKDEV(driver->major, driver->minor_start+number); | ||
554 | struct dentry *dentry; | 560 | struct dentry *dentry; |
555 | struct super_block *sb = pts_sb_from_inode(ptmx_inode); | 561 | struct super_block *sb = pts_sb_from_inode(ptmx_inode); |
556 | struct inode *inode = new_inode(sb); | 562 | struct inode *inode; |
557 | struct dentry *root = sb->s_root; | 563 | struct dentry *root = sb->s_root; |
558 | struct pts_fs_info *fsi = DEVPTS_SB(sb); | 564 | struct pts_fs_info *fsi = DEVPTS_SB(sb); |
559 | struct pts_mount_opts *opts = &fsi->mount_opts; | 565 | struct pts_mount_opts *opts = &fsi->mount_opts; |
560 | int ret = 0; | ||
561 | char s[12]; | 566 | char s[12]; |
562 | 567 | ||
563 | /* We're supposed to be given the slave end of a pty */ | 568 | inode = new_inode(sb); |
564 | BUG_ON(driver->type != TTY_DRIVER_TYPE_PTY); | ||
565 | BUG_ON(driver->subtype != PTY_TYPE_SLAVE); | ||
566 | |||
567 | if (!inode) | 569 | if (!inode) |
568 | return -ENOMEM; | 570 | return ERR_PTR(-ENOMEM); |
569 | 571 | ||
570 | inode->i_ino = number + 3; | 572 | inode->i_ino = index + 3; |
571 | inode->i_uid = opts->setuid ? opts->uid : current_fsuid(); | 573 | inode->i_uid = opts->setuid ? opts->uid : current_fsuid(); |
572 | inode->i_gid = opts->setgid ? opts->gid : current_fsgid(); | 574 | inode->i_gid = opts->setgid ? opts->gid : current_fsgid(); |
573 | inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; | 575 | inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; |
574 | init_special_inode(inode, S_IFCHR|opts->mode, device); | 576 | init_special_inode(inode, S_IFCHR|opts->mode, device); |
575 | inode->i_private = tty; | 577 | inode->i_private = priv; |
576 | tty->driver_data = inode; | ||
577 | 578 | ||
578 | sprintf(s, "%d", number); | 579 | sprintf(s, "%d", index); |
579 | 580 | ||
580 | mutex_lock(&root->d_inode->i_mutex); | 581 | mutex_lock(&root->d_inode->i_mutex); |
581 | 582 | ||
@@ -585,18 +586,24 @@ int devpts_pty_new(struct inode *ptmx_inode, struct tty_struct *tty) | |||
585 | fsnotify_create(root->d_inode, dentry); | 586 | fsnotify_create(root->d_inode, dentry); |
586 | } else { | 587 | } else { |
587 | iput(inode); | 588 | iput(inode); |
588 | ret = -ENOMEM; | 589 | inode = ERR_PTR(-ENOMEM); |
589 | } | 590 | } |
590 | 591 | ||
591 | mutex_unlock(&root->d_inode->i_mutex); | 592 | mutex_unlock(&root->d_inode->i_mutex); |
592 | 593 | ||
593 | return ret; | 594 | return inode; |
594 | } | 595 | } |
595 | 596 | ||
596 | struct tty_struct *devpts_get_tty(struct inode *pts_inode, int number) | 597 | /** |
598 | * devpts_get_priv -- get private data for a slave | ||
599 | * @pts_inode: inode of the slave | ||
600 | * | ||
601 | * Returns whatever was passed as priv in devpts_pty_new for a given inode. | ||
602 | */ | ||
603 | void *devpts_get_priv(struct inode *pts_inode) | ||
597 | { | 604 | { |
598 | struct dentry *dentry; | 605 | struct dentry *dentry; |
599 | struct tty_struct *tty; | 606 | void *priv = NULL; |
600 | 607 | ||
601 | BUG_ON(pts_inode->i_rdev == MKDEV(TTYAUX_MAJOR, PTMX_MINOR)); | 608 | BUG_ON(pts_inode->i_rdev == MKDEV(TTYAUX_MAJOR, PTMX_MINOR)); |
602 | 609 | ||
@@ -605,18 +612,22 @@ struct tty_struct *devpts_get_tty(struct inode *pts_inode, int number) | |||
605 | if (!dentry) | 612 | if (!dentry) |
606 | return NULL; | 613 | return NULL; |
607 | 614 | ||
608 | tty = NULL; | ||
609 | if (pts_inode->i_sb->s_magic == DEVPTS_SUPER_MAGIC) | 615 | if (pts_inode->i_sb->s_magic == DEVPTS_SUPER_MAGIC) |
610 | tty = (struct tty_struct *)pts_inode->i_private; | 616 | priv = pts_inode->i_private; |
611 | 617 | ||
612 | dput(dentry); | 618 | dput(dentry); |
613 | 619 | ||
614 | return tty; | 620 | return priv; |
615 | } | 621 | } |
616 | 622 | ||
617 | void devpts_pty_kill(struct tty_struct *tty) | 623 | /** |
624 | * devpts_pty_kill -- remove inode form /dev/pts/ | ||
625 | * @inode: inode of the slave to be removed | ||
626 | * | ||
627 | * This is an inverse operation of devpts_pty_new. | ||
628 | */ | ||
629 | void devpts_pty_kill(struct inode *inode) | ||
618 | { | 630 | { |
619 | struct inode *inode = tty->driver_data; | ||
620 | struct super_block *sb = pts_sb_from_inode(inode); | 631 | struct super_block *sb = pts_sb_from_inode(inode); |
621 | struct dentry *root = sb->s_root; | 632 | struct dentry *root = sb->s_root; |
622 | struct dentry *dentry; | 633 | struct dentry *dentry; |