summaryrefslogtreecommitdiffstats
path: root/fs/coda
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2016-01-22 15:40:57 -0500
committerAl Viro <viro@zeniv.linux.org.uk>2016-01-22 18:04:28 -0500
commit5955102c9984fa081b2d570cfac75c97eecf8f3b (patch)
treea4744386eac4b916e847eb4eedfada158f6527b4 /fs/coda
parent57b8f112cfe6622ddddb8c2641206bb5fa8a112d (diff)
wrappers for ->i_mutex access
parallel to mutex_{lock,unlock,trylock,is_locked,lock_nested}, inode_foo(inode) being mutex_foo(&inode->i_mutex). Please, use those for access to ->i_mutex; over the coming cycle ->i_mutex will become rwsem, with ->lookup() done with it held only shared. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/coda')
-rw-r--r--fs/coda/dir.c4
-rw-r--r--fs/coda/file.c8
2 files changed, 6 insertions, 6 deletions
diff --git a/fs/coda/dir.c b/fs/coda/dir.c
index fda9f4311212..42e731b8c80a 100644
--- a/fs/coda/dir.c
+++ b/fs/coda/dir.c
@@ -427,13 +427,13 @@ static int coda_readdir(struct file *coda_file, struct dir_context *ctx)
427 if (host_file->f_op->iterate) { 427 if (host_file->f_op->iterate) {
428 struct inode *host_inode = file_inode(host_file); 428 struct inode *host_inode = file_inode(host_file);
429 429
430 mutex_lock(&host_inode->i_mutex); 430 inode_lock(host_inode);
431 ret = -ENOENT; 431 ret = -ENOENT;
432 if (!IS_DEADDIR(host_inode)) { 432 if (!IS_DEADDIR(host_inode)) {
433 ret = host_file->f_op->iterate(host_file, ctx); 433 ret = host_file->f_op->iterate(host_file, ctx);
434 file_accessed(host_file); 434 file_accessed(host_file);
435 } 435 }
436 mutex_unlock(&host_inode->i_mutex); 436 inode_unlock(host_inode);
437 return ret; 437 return ret;
438 } 438 }
439 /* Venus: we must read Venus dirents from a file */ 439 /* Venus: we must read Venus dirents from a file */
diff --git a/fs/coda/file.c b/fs/coda/file.c
index 1da3805f3ddc..f47c7483863b 100644
--- a/fs/coda/file.c
+++ b/fs/coda/file.c
@@ -71,12 +71,12 @@ coda_file_write_iter(struct kiocb *iocb, struct iov_iter *to)
71 71
72 host_file = cfi->cfi_container; 72 host_file = cfi->cfi_container;
73 file_start_write(host_file); 73 file_start_write(host_file);
74 mutex_lock(&coda_inode->i_mutex); 74 inode_lock(coda_inode);
75 ret = vfs_iter_write(cfi->cfi_container, to, &iocb->ki_pos); 75 ret = vfs_iter_write(cfi->cfi_container, to, &iocb->ki_pos);
76 coda_inode->i_size = file_inode(host_file)->i_size; 76 coda_inode->i_size = file_inode(host_file)->i_size;
77 coda_inode->i_blocks = (coda_inode->i_size + 511) >> 9; 77 coda_inode->i_blocks = (coda_inode->i_size + 511) >> 9;
78 coda_inode->i_mtime = coda_inode->i_ctime = CURRENT_TIME_SEC; 78 coda_inode->i_mtime = coda_inode->i_ctime = CURRENT_TIME_SEC;
79 mutex_unlock(&coda_inode->i_mutex); 79 inode_unlock(coda_inode);
80 file_end_write(host_file); 80 file_end_write(host_file);
81 return ret; 81 return ret;
82} 82}
@@ -203,7 +203,7 @@ int coda_fsync(struct file *coda_file, loff_t start, loff_t end, int datasync)
203 err = filemap_write_and_wait_range(coda_inode->i_mapping, start, end); 203 err = filemap_write_and_wait_range(coda_inode->i_mapping, start, end);
204 if (err) 204 if (err)
205 return err; 205 return err;
206 mutex_lock(&coda_inode->i_mutex); 206 inode_lock(coda_inode);
207 207
208 cfi = CODA_FTOC(coda_file); 208 cfi = CODA_FTOC(coda_file);
209 BUG_ON(!cfi || cfi->cfi_magic != CODA_MAGIC); 209 BUG_ON(!cfi || cfi->cfi_magic != CODA_MAGIC);
@@ -212,7 +212,7 @@ int coda_fsync(struct file *coda_file, loff_t start, loff_t end, int datasync)
212 err = vfs_fsync(host_file, datasync); 212 err = vfs_fsync(host_file, datasync);
213 if (!err && !datasync) 213 if (!err && !datasync)
214 err = venus_fsync(coda_inode->i_sb, coda_i2f(coda_inode)); 214 err = venus_fsync(coda_inode->i_sb, coda_i2f(coda_inode));
215 mutex_unlock(&coda_inode->i_mutex); 215 inode_unlock(coda_inode);
216 216
217 return err; 217 return err;
218} 218}