cifs: Process post session setup code in respective dialect functions.

Move the post (successful) session setup code to respective dialect routines.

For smb1, session key is per smb connection.
For smb2/smb3, session key is per smb session.

If client and server do not require signing, free session key for smb1/2/3.

If client and server require signing
  smb1 - Copy (kmemdup) session key for the first session to connection.
         Free session key of that and subsequent sessions on this connection.
  smb2 - For every session, keep the session key and free it when the
         session is being shutdown.
  smb3 - For every session, generate the smb3 signing key using the session key
         and then free the session key.

There are two unrelated line formatting changes as well.

Reviewed-by: Jeff Layton <jlayton@samba.org>
Signed-off-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Signed-off-by: Steve French <smfrench@gmail.com>

1 files changed, 1 insertions, 26 deletions

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index b1bab99be83b..688f48ec9abc 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -3828,33 +3828,8 @@ cifs_setup_session(const unsigned int xid, struct cifs_ses *ses,
         if (server->ops->sess_setup)
                 rc = server->ops->sess_setup(xid, ses, nls_info);
 
-        if (rc) {
+        if (rc)
                 cifs_dbg(VFS, "Send error in SessSetup = %d\n", rc);
-        } else {
-                mutex_lock(&server->srv_mutex);
-                if (!server->session_estab) {
-                        server->session_key.response = ses->auth_key.response;
-                        server->session_key.len = ses->auth_key.len;
-                        server->sequence_number = 0x2;
-                        server->session_estab = true;
-                        ses->auth_key.response = NULL;
-                        if (server->ops->generate_signingkey)
-                                server->ops->generate_signingkey(server);
-                }
-                mutex_unlock(&server->srv_mutex);
-
-                cifs_dbg(FYI, "CIFS Session Established successfully\n");
-                spin_lock(&GlobalMid_Lock);
-                ses->status = CifsGood;
-                ses->need_reconnect = false;
-                spin_unlock(&GlobalMid_Lock);
-        }
-
-        kfree(ses->auth_key.response);
-        ses->auth_key.response = NULL;
-        ses->auth_key.len = 0;
-        kfree(ses->ntlmssp);
-        ses->ntlmssp = NULL;
 
         return rc;
 }