diff options
author | Chengguang Xu <cgxu519@icloud.com> | 2018-02-23 04:09:38 -0500 |
---|---|---|
committer | Ilya Dryomov <idryomov@gmail.com> | 2018-04-02 04:12:46 -0400 |
commit | b884014a91a49ed0e7198d276b28887cc48363bd (patch) | |
tree | 5bef0732e3736d68dbb5c57f60bc532d3fe74d40 /fs/ceph/caps.c | |
parent | f2f87877b8f29a4aa0000a2e3cdf806ac645500e (diff) |
ceph: adding protection for showing cap reservation info
Adding spinlock protection during getting cap reservation
ralated fields so that the numbers match below BUG_ON condition
in the code.
BUG_ON(mdsc->caps_total_count != mdsc->caps_use_count +
mdsc->caps_reserve_count +
mdsc->caps_avail_count);
Signed-off-by: Chengguang Xu <cgxu519@icloud.com>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Diffstat (limited to 'fs/ceph/caps.c')
-rw-r--r-- | fs/ceph/caps.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c index 0e5bd3e3344e..1d02648788e3 100644 --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c | |||
@@ -341,6 +341,8 @@ void ceph_reservation_status(struct ceph_fs_client *fsc, | |||
341 | { | 341 | { |
342 | struct ceph_mds_client *mdsc = fsc->mdsc; | 342 | struct ceph_mds_client *mdsc = fsc->mdsc; |
343 | 343 | ||
344 | spin_lock(&mdsc->caps_list_lock); | ||
345 | |||
344 | if (total) | 346 | if (total) |
345 | *total = mdsc->caps_total_count; | 347 | *total = mdsc->caps_total_count; |
346 | if (avail) | 348 | if (avail) |
@@ -351,6 +353,8 @@ void ceph_reservation_status(struct ceph_fs_client *fsc, | |||
351 | *reserved = mdsc->caps_reserve_count; | 353 | *reserved = mdsc->caps_reserve_count; |
352 | if (min) | 354 | if (min) |
353 | *min = mdsc->caps_min_count; | 355 | *min = mdsc->caps_min_count; |
356 | |||
357 | spin_unlock(&mdsc->caps_list_lock); | ||
354 | } | 358 | } |
355 | 359 | ||
356 | /* | 360 | /* |