summaryrefslogtreecommitdiffstats
path: root/fs/buffer.c
diff options
context:
space:
mode:
authorRoss Zwisler <ross.zwisler@linux.intel.com>2015-10-13 18:51:02 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2015-11-11 02:19:33 -0500
commit5c50002963369c7c622b18ff751719eadbe225c5 (patch)
treef475c0c337b79a5c8085e2c9b91dc2cec1d4ef18 /fs/buffer.c
parent54d15714f7497094a0839537f0d47946edb45761 (diff)
vfs: remove unused wrapper block_page_mkwrite()
The function currently called "__block_page_mkwrite()" used to be called "block_page_mkwrite()" until a wrapper for this function was added by: commit 24da4fab5a61 ("vfs: Create __block_page_mkwrite() helper passing error values back") This wrapper, the current "block_page_mkwrite()", is currently unused. __block_page_mkwrite() is used directly by ext4, nilfs2 and xfs. Remove the unused wrapper, rename __block_page_mkwrite() back to block_page_mkwrite() and update the comment above block_page_mkwrite(). Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> Reviewed-by: Jan Kara <jack@suse.com> Cc: Jan Kara <jack@suse.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/buffer.c')
-rw-r--r--fs/buffer.c24
1 files changed, 2 insertions, 22 deletions
diff --git a/fs/buffer.c b/fs/buffer.c
index 51aff0296ce2..4f4cd959da7c 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -2420,9 +2420,9 @@ EXPORT_SYMBOL(block_commit_write);
2420 * unlock the page. 2420 * unlock the page.
2421 * 2421 *
2422 * Direct callers of this function should protect against filesystem freezing 2422 * Direct callers of this function should protect against filesystem freezing
2423 * using sb_start_write() - sb_end_write() functions. 2423 * using sb_start_pagefault() - sb_end_pagefault() functions.
2424 */ 2424 */
2425int __block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf, 2425int block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf,
2426 get_block_t get_block) 2426 get_block_t get_block)
2427{ 2427{
2428 struct page *page = vmf->page; 2428 struct page *page = vmf->page;
@@ -2459,26 +2459,6 @@ out_unlock:
2459 unlock_page(page); 2459 unlock_page(page);
2460 return ret; 2460 return ret;
2461} 2461}
2462EXPORT_SYMBOL(__block_page_mkwrite);
2463
2464int block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf,
2465 get_block_t get_block)
2466{
2467 int ret;
2468 struct super_block *sb = file_inode(vma->vm_file)->i_sb;
2469
2470 sb_start_pagefault(sb);
2471
2472 /*
2473 * Update file times before taking page lock. We may end up failing the
2474 * fault so this update may be superfluous but who really cares...
2475 */
2476 file_update_time(vma->vm_file);
2477
2478 ret = __block_page_mkwrite(vma, vmf, get_block);
2479 sb_end_pagefault(sb);
2480 return block_page_mkwrite_return(ret);
2481}
2482EXPORT_SYMBOL(block_page_mkwrite); 2462EXPORT_SYMBOL(block_page_mkwrite);
2483 2463
2484/* 2464/*