diff options
author | Qu Wenruo <wqu@suse.com> | 2019-03-13 00:17:50 -0400 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2019-04-29 13:02:32 -0400 |
commit | 80e46cf22ba0bcb57b39c7c3b52961ab3a0fd5f2 (patch) | |
tree | c9f17084a41716eb0cf1fdd900d87e0848948b78 /fs/btrfs/tree-checker.c | |
parent | ab4ba2e133463c702b37242560d7fabedd2dc750 (diff) |
btrfs: tree-checker: Enhance chunk checker to validate chunk profile
Btrfs-progs already have a comprehensive type checker, to ensure there
is only 0 (SINGLE profile) or 1 (DUP/RAID0/1/5/6/10) bit set for chunk
profile bits.
Do the same work for kernel.
Reported-by: Yoon Jungyeon <jungyeon@gatech.edu>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=202765
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/tree-checker.c')
-rw-r--r-- | fs/btrfs/tree-checker.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c index 00ab4e783b9f..d7f4a3468945 100644 --- a/fs/btrfs/tree-checker.c +++ b/fs/btrfs/tree-checker.c | |||
@@ -556,6 +556,13 @@ int btrfs_check_chunk_valid(struct btrfs_fs_info *fs_info, | |||
556 | return -EUCLEAN; | 556 | return -EUCLEAN; |
557 | } | 557 | } |
558 | 558 | ||
559 | if (!is_power_of_2(type & BTRFS_BLOCK_GROUP_PROFILE_MASK) && | ||
560 | (type & BTRFS_BLOCK_GROUP_PROFILE_MASK) != 0) { | ||
561 | chunk_err(fs_info, leaf, chunk, logical, | ||
562 | "invalid chunk profile flag: 0x%llx, expect 0 or 1 bit set", | ||
563 | type & BTRFS_BLOCK_GROUP_PROFILE_MASK); | ||
564 | return -EUCLEAN; | ||
565 | } | ||
559 | if ((type & BTRFS_BLOCK_GROUP_TYPE_MASK) == 0) { | 566 | if ((type & BTRFS_BLOCK_GROUP_TYPE_MASK) == 0) { |
560 | chunk_err(fs_info, leaf, chunk, logical, | 567 | chunk_err(fs_info, leaf, chunk, logical, |
561 | "missing chunk type flag, have 0x%llx one bit must be set in 0x%llx", | 568 | "missing chunk type flag, have 0x%llx one bit must be set in 0x%llx", |