summaryrefslogtreecommitdiffstats
path: root/fs/btrfs/locking.c
diff options
context:
space:
mode:
authorDavid Sterba <dsterba@suse.com>2018-08-24 10:20:02 -0400
committerDavid Sterba <dsterba@suse.com>2019-04-29 13:02:21 -0400
commite3f153886702302482918a3788ba3bb24a37a4aa (patch)
treee14a716a1f40cfe67d09eacc37018dea15aec259 /fs/btrfs/locking.c
parent5c9c799ab78336a4161b16126952a7e1320a8c77 (diff)
btrfs: add assertion helpers for extent buffer write lock counters
The write_locks are a simple counter to track locking balance and used to assert tree locks. Add helpers to make it conditionally work only in DEBUG builds. Will be used in followup patches. Reviewed-by: Nikolay Borisov <nborisov@suse.com> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/locking.c')
-rw-r--r--fs/btrfs/locking.c23
1 files changed, 18 insertions, 5 deletions
diff --git a/fs/btrfs/locking.c b/fs/btrfs/locking.c
index 1088cf322fdd..1c9bb0620e4b 100644
--- a/fs/btrfs/locking.c
+++ b/fs/btrfs/locking.c
@@ -56,6 +56,21 @@ static void btrfs_assert_tree_read_locked(struct extent_buffer *eb)
56 BUG_ON(!atomic_read(&eb->read_locks)); 56 BUG_ON(!atomic_read(&eb->read_locks));
57} 57}
58 58
59static void btrfs_assert_tree_write_locks_get(struct extent_buffer *eb)
60{
61 atomic_inc(&eb->write_locks);
62}
63
64static void btrfs_assert_tree_write_locks_put(struct extent_buffer *eb)
65{
66 atomic_dec(&eb->write_locks);
67}
68
69void btrfs_assert_tree_locked(struct extent_buffer *eb)
70{
71 BUG_ON(!atomic_read(&eb->write_locks));
72}
73
59#else 74#else
60static void btrfs_assert_spinning_writers_get(struct extent_buffer *eb) { } 75static void btrfs_assert_spinning_writers_get(struct extent_buffer *eb) { }
61static void btrfs_assert_spinning_writers_put(struct extent_buffer *eb) { } 76static void btrfs_assert_spinning_writers_put(struct extent_buffer *eb) { }
@@ -65,6 +80,9 @@ static void btrfs_assert_spinning_readers_get(struct extent_buffer *eb) { }
65static void btrfs_assert_tree_read_locked(struct extent_buffer *eb) { } 80static void btrfs_assert_tree_read_locked(struct extent_buffer *eb) { }
66static void btrfs_assert_tree_read_locks_get(struct extent_buffer *eb) { } 81static void btrfs_assert_tree_read_locks_get(struct extent_buffer *eb) { }
67static void btrfs_assert_tree_read_locks_put(struct extent_buffer *eb) { } 82static void btrfs_assert_tree_read_locks_put(struct extent_buffer *eb) { }
83void btrfs_assert_tree_locked(struct extent_buffer *eb) { }
84static void btrfs_assert_tree_write_locks_get(struct extent_buffer *eb) { }
85static void btrfs_assert_tree_write_locks_put(struct extent_buffer *eb) { }
68#endif 86#endif
69 87
70void btrfs_set_lock_blocking_read(struct extent_buffer *eb) 88void btrfs_set_lock_blocking_read(struct extent_buffer *eb)
@@ -320,8 +338,3 @@ void btrfs_tree_unlock(struct extent_buffer *eb)
320 write_unlock(&eb->lock); 338 write_unlock(&eb->lock);
321 } 339 }
322} 340}
323
324void btrfs_assert_tree_locked(struct extent_buffer *eb)
325{
326 BUG_ON(!atomic_read(&eb->write_locks));
327}